Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed slider overlapping by GitHub SVG in Mobile View. #208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed slider overlapping by GitHub SVG in Mobile View. #208

wants to merge 2 commits into from

Conversation

dkapur17
Copy link
Contributor

Fixes #
Moved the slider and message "Edit on github" a little lower so that it isn't overlapped by the SVG.

Describe the changes you have made -

Added margin-top to the slider and the div containing "Edit on github" in themes.css.

Screenshots of the changes (If any) -

Before

Overlapped-Slider-Issue

After

Overlapped-Slider-Fixed

Referencing Issue #177

@dkapur17 dkapur17 changed the title Fixed slider overlapping by GitHub SVG. Fixed slider overlapping by GitHub SVG in Mobile View. Feb 27, 2020
@YashKumarVerma
Copy link
Member

@Shivansh2407 are you facing a similar issue?
I think i am not.

@Shivansh2407
Copy link
Member

No @YashKumarVerma I am also not facing this issue. @dkapur17 can you list the steps to reproduce the mentioned Issue. Also it is better to first raise an issue and then open up a PR regarding the same.

@YashKumarVerma YashKumarVerma added the inactive inactive for a significant peiod, would be closed in near future label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive inactive for a significant peiod, would be closed in near future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants