Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing Username and Educational Institue name overflow. #4936

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MostlyKIGuess
Copy link

@MostlyKIGuess MostlyKIGuess commented May 14, 2024

Fixes #4801

Describe the changes you have made in this PR -

It now prevents the user to write big names into username and educational institute fields.
Added a simple js code so that the user gets a warning like this:

image
image

and doesn't let him update unless it's under 200 and 400 characters for name and educational institute name respectively.

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

codeclimate bot commented May 14, 2024

Code Climate has analyzed commit 0f11c7b and detected 0 issues on this pull request.

View more on Code Climate.

@MostlyKIGuess
Copy link
Author

@tanmoysrt Do review this sir.

@MostlyKIGuess
Copy link
Author

@tanmoysrt should I make any other changes?

@tanmoysrt
Copy link
Member

Hi @MostlyKIGuess
Thanks for raising the PR.

  1. The issue is not yet approved and pending triage label hasn't removed
  2. Contributors are assigned in first come basis. So, after verifying issue, if issue creator want to pass it to next, you will be assigned and you can raise the PR
  3. We are moving from JQuery. So if you do any changes on frontend JS, do that in vanilla js instead of JQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Bug : No word limit in Name and Educational Institution field in Profile
2 participants