Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding dark mode functionality to blog #101

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AsherThomasBabu
Copy link

@AsherThomasBabu AsherThomasBabu commented Aug 24, 2021

This PR is intended to add dark mode functionality to the blog and closes #56 on merge

In order to override the third party theme, I had to bring the index.html and header.html files to the local repo. I'm not sure if this is a right practice, but seems like the only way.

I also had to remove the SVG background on the hero of the blog, this could either be added in as CSS or left out as such.
The Illustration on the hero also seems a little shabby, If a higher quality image can be linked, that too can be added.

Looking for further input on what else can be improved.

This is a snip of how the current dark mode looks like.
Screenshot 2021-08-24 at 12-08-34 CircuitVerse Blog(1)

@commit-lint
Copy link

commit-lint bot commented Aug 24, 2021

Contributors

AsherThomasBabu

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@AsherThomasBabu AsherThomasBabu changed the title Adding dark mode functionality to blog feat: Adding dark mode functionality to blog Aug 24, 2021
@AsherThomasBabu AsherThomasBabu changed the title feat: Adding dark mode functionality to blog feat: dding dark mode functionality to blog Aug 24, 2021
@AsherThomasBabu AsherThomasBabu changed the title feat: dding dark mode functionality to blog feat: adding dark mode functionality to blog Aug 24, 2021
@tachyons
Copy link
Member

tachyons commented Dec 3, 2021

Any update on upstreaming the changes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dark mode functionality
2 participants