Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created states for countries (country codes a-c) #7028

Conversation

romdricks
Copy link
Contributor

@romdricks romdricks commented May 16, 2024

Description

Created states for: Andorra, United Arab Emirates, Afghanistan, Albania, Armenia, Angola, Antarctica, Argentina, American Samoa,
Anguilla, Åland Islands, Azerbaijan, Bosnia and Herzegovina, Bangladesh, Belgium, Burkina Faso, Bulgaria, Bahrain, Burundi, Benin, Saint Barthélemy, Bermuda, Brunei, Bolivia, Brazil, Bhutan, Bouvet Island, Botswana, Belarus, Belize, Cocos (Keeling) Islands, Congo (DRC), Central African Republic, Congo (Republic), Switzerland, Côte d’Ivoire, Cook Islands, Chile, Cameroon, China, Colombia, Costa Rica, Cape Verde, Curaçao, Christmas Island, Cyprus and Czech Republic.

Type of change

  • New feature (non-breaking change which adds functionality)

@romdricks romdricks requested a review from a team as a code owner May 16, 2024 02:24
@romdricks romdricks requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 16, 2024 02:24
@respencer
Copy link
Contributor

respencer commented May 16, 2024

Just a couple of quick observations:

  1. There seems to be an inconsistent use of keys (some are letters, some are numbers, different number styles, mixed) -- that all needs to be verified.
  2. Preference is to sort in alphabetical order by key (that's not always the case in this commit).
  3. Some of the 'xx' entries are not states, but I would accept it as it can be used as a trigger in future to disable the display of the states form fields for those countries and territories.

PS: I'd forgotten how messed up the upstream data sources are. Some of the inconstancy are due to that.

@romdricks
Copy link
Contributor Author

Just a couple of quick observations:

1. There seems to be an inconsistent use of keys (some are letters, some are numbers, different number styles, mixed) -- that all needs to be verified.

2. Preference is to sort in alphabetical order by key (that's not always the case in this commit).

3. Some of the 'xx' entries are not states, but I would accept it as it can be used as a trigger in future to disable the display of the states form fields for those countries and territories.

PS: I'd forgotten how messed up the upstream data sources are. Some of the inconstancy are due to that.

Thanks for your feedback.

  1. That's how some are. You can verify with this site as well https://www.iso.org/obp/ui/#search
  2. Would this affects it from appearing in alphabetical order in the state dropdown list?
  3. Good idea. Also, could the state form field be disabled or auto populated whenever there is a selection in the state dropdown list? I realized the field is mandatory in the registration form, which cause the user to input the state again.

@respencer
Copy link
Contributor

Thanks for your feedback.

1. That's how some are. You can verify with this site as well https://www.iso.org/obp/ui/#search
2. Would this affects it from appearing in alphabetical order in the state dropdown list?
3. Good idea. Also, could the state form field be disabled or auto populated whenever there is a selection in the state dropdown list? I realized the field is mandatory in the registration form, which cause the user to input the state again.
  1. Yeah.
  2. iirc, yes.
  3. Unfortunately no. Will have to be something we work towards. That last bit sounds like a bug though, since some places have no states. Can you please screenshot the page with the field you are referring to highlighted?

Copy link
Contributor

@respencer respencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my tests have passed.

@romdricks
Copy link
Contributor Author

Thanks for your feedback.

1. That's how some are. You can verify with this site as well https://www.iso.org/obp/ui/#search
2. Would this affects it from appearing in alphabetical order in the state dropdown list?
3. Good idea. Also, could the state form field be disabled or auto populated whenever there is a selection in the state dropdown list? I realized the field is mandatory in the registration form, which cause the user to input the state again.
1. Yeah.

2. iirc, yes.

3. Unfortunately no. Will have to be something we work towards. That last bit sounds like a bug though, since some places have no states. Can you please screenshot the page with the field you are referring to highlighted?

Ok, understand. Here is screenshot of the self registration page:
Screenshot 2024-05-16 153450

@romdricks
Copy link
Contributor Author

All my tests have passed.

Awesome!

@respencer respencer force-pushed the Created-states-for-countries-(country-codes-a-c) branch from e81010c to 8ee7c72 Compare May 17, 2024 06:15
@respencer respencer force-pushed the Created-states-for-countries-(country-codes-a-c) branch 2 times, most recently from 3a1d89b to 1da1131 Compare May 22, 2024 18:31
@respencer respencer force-pushed the Created-states-for-countries-(country-codes-a-c) branch from 1da1131 to be871c1 Compare May 25, 2024 13:44
@DAcodedBEAT DAcodedBEAT merged commit 912b2e2 into ChurchCRM:master May 26, 2024
3 checks passed
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.9.0) milestone May 26, 2024
@romdricks romdricks deleted the Created-states-for-countries-(country-codes-a-c) branch May 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants