Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#926: Maintain groups in search mode #1152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefan-korn
Copy link

@stefan-korn stefan-korn commented Mar 19, 2024

Description

Proposal for solving #926
Add a new bool config option "appendGroupInSearch". If this is set to true the group of an option will be appended to the name of the option when searching.

This is somehow a workaround, because I was not able at this moment to keep the goups like in the inital state when not searching.

But at least this should help if you have the same label for options in different groups.

Remark: to run a build of the project I needed to remove the bundlesize library. This does at least not seem to work with latest (later) node version, because it requires very old (0.1.0) version of brotli-size and this requires deprecated iltorb package. Did not commit changes to package.json/package-lock.json though.

Screenshots (if appropriate)

choices_screen
(the group City/State appended to the choice New York/Nevada/Pennsylvania)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant