[BUGFIX] Check for constructor name of element on bootstrap #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check using `instanceof` fails in case the Choices.js component is rendered in the `top` frame while the JavaScript actually using Choices.js is in an iframe. The conditions are changed to check for `constructor.name` now, solving the issue. Due to the rather messy constructor, some quirks like operational chaining and explicit type casts need to be used to make the TypeScript compiling process happy. Fixes: Choices-js#1057
mtriff
reviewed
Nov 17, 2022
| @@ -306,7 +306,7 @@ function () { | |||
|
|
|||
| var passedElement = typeof element === 'string' ? document.querySelector(element) : element; | |||
|
|
|||
| if (!(passedElement instanceof HTMLInputElement || passedElement instanceof HTMLSelectElement)) { | |||
| if (!((passedElement === null || passedElement === void 0 ? void 0 : passedElement.constructor.name) === 'HTMLInputElement' || (passedElement === null || passedElement === void 0 ? void 0 : passedElement.constructor.name) === 'HTMLSelectElement')) { | |||
There was a problem hiding this comment.
This change is more complex than what you've done elsewhere, does it need to be?
Assuming they can all be the same, let's move this functionality out to a function in utils.ts:
export const isHTMLInputOrSelectElement = (element: HTMLElement): boolean => {
const constructorName = element?.constructor.name;
if (constructorName === 'HTMLInputElement' || constructorName === 'HTMLSelectElement') {
return true;
}
return false;
}
mtriff
added
the
changes required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous check using
instanceoffails in case the Choices.js component is rendered in thetopframe while the JavaScript actually using Choices.js is in an iframe.The conditions are changed to check for
constructor.namenow, solving the issue.Due to the rather messy constructor, some quirks like operational chaining and explicit type casts need to be used to make the TypeScript compiling process happy.
This fixes #1057.
Screenshots (if appropriate)
Types of changes
Checklist