Remote runner upload success file using external url #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyhb
force-pushed
the
hbaudesson/remote-runner-upload-external-url
branch
2 times, most recently
from
f9f5022
to
29af130
Compare
lunika
reviewed
Dec 22, 2023
Chocobozzz
reviewed
Jan 12, 2024
polyhb
force-pushed
the
hbaudesson/remote-runner-upload-external-url
branch
2 times, most recently
from
2e39bb7
to
bbf19d2
Compare
Remote runner can now upload a success file using directly to a given url instead to the server. It avoids the server to have to download the file and upload it again, thus reducing resources usage.
polyhb
force-pushed
the
hbaudesson/remote-runner-upload-external-url
branch
from
bbf19d2
to
2ff8bc1
Compare
Chocobozzz
reviewed
Feb 27, 2024
| @@ -116,7 +116,9 @@ export async function processHLSTranscoding (options: ProcessOptions<RunnerJobVO | |||
|
|
|||
| const successBody: VODHLSTranscodingSuccess = { | |||
| resolutionPlaylistFile: outputPath, | |||
| videoFile: videoPath | |||
| videoFile: videoPath, | |||
| uploadVideoFileUrl: payload.output.videoFileUrl, | |||
There was a problem hiding this comment.
Why do we specify this in the body success?
I think we should do one of the following:
- the S3 URL of the object
- a boolean specifying the runner uploaded the resource on S3
- nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal is to make the remote runner upload success files using directly a given url instead of sending them to the server. It avoids the server to have to download the file and upload it again, thus reducing resources usage.
This is an implementation proposition for the
HLSTranscodingjobs. After your feedback and if you are ok with this, I'll do the same for the other jobs.Related issues
#6130
Has this been tested?