Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not leaving request stream loop when error occured #178

Open
wants to merge 0 commits into
base: master
Choose a base branch
from
Open

not leaving request stream loop when error occured #178

wants to merge 0 commits into from

Conversation

wangxufire
Copy link

ignore any error and continue loop

@muesli
Copy link
Collaborator

muesli commented Sep 2, 2017

@wangxufire: Is this really the sensible thing to do here? Which situation would it improve?

@muesli
Copy link
Collaborator

muesli commented Oct 20, 2017

That being said, you are clearly right that this situation should be handled better. I just think the real fix needs better error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wangxufire @muesli