馃懛 add Axe in pr-workflow #121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sindre Kjelsrud <kjelsrudsindre@gmail.com>
SindreKjelsrud
changed the title
There was a problem hiding this comment.
Where is the app that we use to test accessibility? ideally we would use the chimera demo page or some standard testing page 馃 We also have to find some way to keep the npm package as lean as possible, to ensure not bloating our consumers projects, while testing 馃 However running axe in the pipeline is absolutely key in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought maybe we could add the automated accessibility testing in our workflows so that it completes issue #100. What do you think @MarkusJohansen?
I do not know if this is an appropriate way to do it, but it seemed like a good idea reading this blog post! 馃槄
I think we need to fix it up a bit for the building of the site for the check..