Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for replace_str_to_bytes #17922

Merged
merged 1 commit into from Apr 30, 2024
Merged

add test for replace_str_to_bytes #17922

merged 1 commit into from Apr 30, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 26, 2024

Purpose:

This function had no test which was exposed when turning it into a free function

@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests labels Apr 26, 2024
@arvidn arvidn requested a review from Rigidity April 26, 2024 19:50
@arvidn arvidn marked this pull request as ready for review April 29, 2024 07:56
@arvidn arvidn requested a review from a team as a code owner April 29, 2024 07:56
@arvidn arvidn requested a review from emlowe April 29, 2024 12:22
@pmaslana pmaslana merged commit 6360ac0 into main Apr 30, 2024
352 of 353 checks passed
@pmaslana pmaslana deleted the replace-str-to-bytes branch April 30, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants