move shfmt execution from the super linter to pre-commit #17913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
I have no idea what shell formatter we should use. But, #17906 was updating the super linter and it started complaining a lot and I really dislike having formatting tools executed in the super linter since that doesn't integrate into our local checks and thus people have to manually apply the super linter results to their local copy. So, this moves the super linter choice of shfmt into our pre-commit setup which runs both locally and in CI.
Current Behavior:
New Behavior:
Testing Notes: