Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gen_and_send_sb and make it type safe #17911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Apr 24, 2024
@AmineKhaldi AmineKhaldi self-assigned this Apr 24, 2024
@AmineKhaldi AmineKhaldi force-pushed the type_safe_simpler_gen_and_send_sb branch from 655f78e to 481ae76 Compare April 24, 2024 15:24
Copy link

Pull Request Test Coverage Report for Build 8819108904

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.008%) to 91.103%

Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 89.0%
chia/wallet/wallet_node.py 1 88.64%
chia/data_layer/data_layer.py 1 84.4%
chia/server/node_discovery.py 4 79.08%
chia/full_node/full_node.py 4 84.81%
Totals Coverage Status
Change from base Build 8809423530: 0.008%
Covered Lines: 98689
Relevant Lines: 108299

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review April 25, 2024 10:58
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner April 25, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants