Use Rust version of MerkleSet #17908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-o-how
added
the
Changed
arvidn
reviewed
Apr 24, 2024
arvidn
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Migrates chia-blockchain to use the rust version of MerkleSet which is included in the latest version of chia_rs.
Note: it does not delete the Python version of MerkleSet just yet as we may want to keep it around a little while for posterity and delete it fully later.
Testing Notes:
The file is tested for Python compatibility in the chia_rs repository and also runs all of the tests in chia-blockchain + a new test of exclusion in
test_wallet_sync.py