Allow additional ClientOSError for expected failure #17899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
CI
arvidn
approved these changes
Apr 26, 2024
altendky
requested changes
Apr 26, 2024
|
Chatting with Earle about some details here and what might be a plausible improvement since we haven't confirmed that this newly accepted error is in fact indicative of the case we are trying to test vs. the existing flakiness of this sort of error being more common now in this test than others. |
|
This is replaced by the fix in #17921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
test_farmer- when testing invalid certificates, also allowClientOSErrorin addition toServerDisconnectErrorThe exact error isn't that important when the connection fails