Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DL autoinserts. #17883

Merged
merged 26 commits into from May 9, 2024
Merged

Optimize DL autoinserts. #17883

merged 26 commits into from May 9, 2024

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica added DataLayer Added Required label for PR that categorizes merge commit message as "Added" for changelog labels Apr 17, 2024
@fchirica fchirica marked this pull request as ready for review April 23, 2024 12:19
@fchirica fchirica requested a review from a team as a code owner April 23, 2024 12:19
@fchirica fchirica closed this Apr 23, 2024
@fchirica fchirica reopened this Apr 23, 2024
@fchirica fchirica closed this Apr 23, 2024
@fchirica fchirica reopened this Apr 23, 2024
@fchirica
Copy link
Contributor Author

PR improves in CI from 1000 inserts in 36s to 25000 inserts in 52s. Locally on my laptop, I can do 100000 single batch inserts in 22s now.

altendky
altendky previously approved these changes Apr 26, 2024
View reviewed changes
altendky
altendky requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are talking through back-compat

altendky
altendky requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested alternate form, feel free to close these conversations if you prefer to keep it as is

chia/_tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
@fchirica @altendky
Apply suggestions from code review
95618e5 
Co-authored-by: Kyle Altendorf <sda@fstab.net>
altendky
altendky previously approved these changes May 7, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 7, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@fchirica fchirica added the ready_to_merge Submitter and reviewers think this is ready label May 8, 2024
@cmmarslender cmmarslender merged commit 6c25d3a into main May 9, 2024
357 checks passed
@cmmarslender cmmarslender deleted the fc.dl_autoinsert_optimize branch May 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog DataLayer ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchirica @altendky @emlowe @cmmarslender