Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change datalayer python and logging from tree id to store id #17864

Merged
merged 10 commits into from May 10, 2024
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Apr 12, 2024

Purpose:

Intended to change:

  • Python variables and attributes
  • Log messages

Intended to remain the same:

  • SQL including named query parameters
  • Serialization such as any configuration, RPC, and plugin messages

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Apr 12, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Apr 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Apr 17, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky changed the title change python and logging from tree id to store id change datalayer python and logging from tree id to store id Apr 22, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Apr 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Apr 26, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

3 similar comments
Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky marked this pull request as ready for review May 9, 2024 17:17
@altendky altendky requested a review from a team as a code owner May 9, 2024 17:17
Copy link
Contributor

github-actions bot commented May 9, 2024

File Coverage Missing Lines
chia/data_layer/data_layer.py 91.5% lines 353, 539, 603, 645, 678, 696, 705, 716, 768, 1158
chia/data_layer/data_layer_util.py 60.0% lines 93-94
chia/data_layer/data_store.py 96.6% lines 663, 727, 1011, 1142
chia/data_layer/download_data.py 95.5% lines 177
chia/data_layer/s3_plugin_service.py 0.0% lines 155-156, 158, 160, 223, 227
chia/data_layer/util/benchmark.py 0.0% lines 27-28, 41, 72, 89, 91, 100
chia/rpc/data_layer_rpc_api.py 50.0% lines 426, 431-432
Total Missing Coverage
585 lines 33 lines 94%

Copy link

Pull Request Test Coverage Report for Build 9018606003

Details

  • 552 of 585 (94.36%) changed or added relevant lines in 14 files are covered.
  • 28 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.793%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/download_data.py 21 22 95.45%
chia/data_layer/data_layer_util.py 3 5 60.0%
chia/rpc/data_layer_rpc_api.py 3 6 50.0%
chia/data_layer/data_store.py 112 116 96.55%
chia/data_layer/s3_plugin_service.py 0 6 0.0%
chia/data_layer/util/benchmark.py 0 7 0.0%
chia/data_layer/data_layer.py 107 117 91.45%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/rpc/data_layer_rpc_api.py 1 83.82%
chia/daemon/server.py 1 83.21%
chia/introducer/introducer.py 1 78.26%
chia/data_layer/data_store.py 2 95.6%
chia/full_node/full_node.py 2 84.81%
chia/rpc/rpc_server.py 3 87.67%
chia/introducer/introducer_api.py 5 78.26%
chia/wallet/wallet_node.py 6 88.58%
chia/server/node_discovery.py 6 79.61%
Totals Coverage Status
Change from base Build 9018383795: -0.02%
Covered Lines: 98935
Relevant Lines: 108910

💛 - Coveralls

@altendky altendky requested a review from emlowe May 10, 2024 00:35
@emlowe
Copy link
Contributor

emlowe commented May 10, 2024

coverage diff exempted with this find/replace naming change

@cmmarslender cmmarslender merged commit 98df4ce into main May 10, 2024
355 of 356 checks passed
@cmmarslender cmmarslender deleted the store_id branch May 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants