Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-414 fixup datalayer benchmark #17786

Merged
merged 17 commits into from May 21, 2024
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Mar 27, 2024

Purpose:

Replace fixed quantity/time batch insert constraints with with big-o constant or linear fit requirement with coefficient restrictions.

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • return benchmark run to running all
  • check TODO:s
  • pick time limits

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Mar 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Apr 16, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 10, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 13, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky changed the title fixup datalayer benchmark fixup datalayer benchmark CHIA-414 May 14, 2024
@altendky altendky changed the title fixup datalayer benchmark CHIA-414 CHIA-414 fixup datalayer benchmark May 14, 2024
@altendky altendky marked this pull request as ready for review May 14, 2024 16:31
@altendky altendky requested a review from a team as a code owner May 14, 2024 16:31
@altendky altendky requested review from fchirica and emlowe May 14, 2024 16:40
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/util/misc.py 20.0% lines 392, 394-396
Total Missing Coverage
16 lines 4 lines 75%

@cmmarslender cmmarslender merged commit 50a5091 into main May 21, 2024
359 of 360 checks passed
@cmmarslender cmmarslender deleted the fixup_datalayer_benchmark branch May 21, 2024 18:41
altendky added a commit that referenced this pull request May 21, 2024
cmmarslender pushed a commit that referenced this pull request May 22, 2024
Revert "CHIA-414 fixup datalayer benchmark (#17786)"

This reverts commit 50a5091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants