Fixed handling for max coin amount when it is set to zero & updated unit tests #16893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack60612
added
the
Fixed
Quexington
reviewed
Nov 20, 2023
Comment on lines
+87
to
+89
| max_coin_amount=uint64(constants.MAX_COIN_AMOUNT) | ||
| if (self.max_coin_amount is None or self.max_coin_amount == 0) | ||
| else self.max_coin_amount, |
There was a problem hiding this comment.
0 as a max coin amount is a valid option to specify so I don't think this is the place to fix this issue. Instead, we should fix whatever is using 0 as an explicit default here.
|
replaced with #15718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Allows transactions to go through when the max coin amount is set to zero, this is commonly used as a default by most cli commands.
Fixes
chia wallet coins combinewhen used with feeResolves #16802
Current Behavior:
when no max coin value is set with some rpc / cli calls, max coin ammt is set to zero so no fees coins can be found.
New Behavior:
max coin amount set to max coin constant, fee coin searching succeeds.
Testing Notes:
Updated Unit tests