IGNORE_ENCHANT_ATTRIBUTE_FOR_SIMILARITY configuration #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 26, 2023 09:43
Add configuration IGNORE_ENCHANT_ATTRIBUTE_FOR_SIMILARITY
|
Player cannot manage Anvil repair-cost. It may be different on the same item and the same Enchants |
|
Seeing as you added support to ignore any key it would be best to also reflect that in the name of the config option. |
… to EXCLUDED_ITEM_ATTRIBUTES
|
@Phoenix616 thanks. I did the update |
Phoenix616
reviewed
Apr 28, 2024
| @@ -337,4 +337,10 @@ public <T> Object parseToJava(Class<T> type, Object object) { | |||
| @PrecededBySpace | |||
| @ConfigurationComment("Add stock counter to quantity line?") | |||
| public static boolean USE_STOCK_COUNTER = false; | |||
|
|
|||
| @PrecededBySpace | |||
| @ConfigurationComment("Exclude these enchantments from the similarity check when comparing items") | |||
There was a problem hiding this comment.
This comment seems wrong to what it now does. Also might want to add an example of what keys are supported here or a link to a site listing those. (Or at least that info in the PR so it can be added to the wiki)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config to ignore Anvil's repair cost and other attributes for enchanted item