Could be python version #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version works with gnu compilers on Windows. Requires python libraries to be installed at hardcoded path at the moment. Testing only. Python script output is copied to CRYSTALS output.
1. Tidy up 2. Find app pyembed folder 3. Prefix stderr output with red colour.
Add embeddable MSVC python dist to precomp. I've added an import library so that MinGW gcc can link it. For future reference, this was generated in two steps: gendef python38.dll dlltool -d python38.def -D python38.dll -llibpython38.a Both tools are part of Msys/MinGW. Added matching python headers (v3.8.1) to the folder python-headers-win
Remove python lib finds from CMakelists, but add local set of python headers (python-win-headers) for function definitions. Attempt to copy .py files from script to script - not working yet. python.c : dynamically load python dll from pyembed (and use python libs from there). This is more work, but reduces a breakable dependency. Note we can't use INCREF and DECREF macros in the c code here due to dependencies on variables in the DLL (which is loaded on request). We can simulate INCREF with Py_BuildValue call - hopefully the only leaking references (2 here) will be cleaned up after each script call by Finalize - if not need to find a workaround.
Don't reinitialze python every time - memory leaks. Rename python.c to cpp (for intel build ease) Use PyRun_SimpleFile instead of PyImport_Import as the latter only executes code on first import.
GeneralDefines misses some key flags
Not Linux version yet.
Download python deps
Test outputs look more stable.
Test compile options py
…t/crystals into could_be_python_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for eventual merge - don't do it yet.