Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to regex postbacks #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ability to regex postbacks #119

wants to merge 2 commits into from

Conversation

FnTm
Copy link

@FnTm FnTm commented Mar 10, 2018

There was an open issue #87 which asked for ability to regex postbacks. Since I also really needed this functionality - I went ahead and did a quick implementation to get the discussion going.

The api is a complete copy of bot.hear(). This also takes in either a string | RegExp or an array of such, and makes a map to verify later.

I can go ahead and add tests for this, if this is something we'd want to move forwards with. @Charca what do you think?

//cc @mraaroncruz @pandawanfr as both of you originally requested this feature.

@FnTm
Copy link
Author

FnTm commented Nov 21, 2019

@Charca I know that I'm committing necromancy by reviving this issue, but what do you think of going ahead with this?
I've been realising that my branch is something like a year behind the master, and I'd like to update to a later version, but also would like to keep using the changes introduced here (I've been using them for more than a year, and no issues yet)

@FnTm
Copy link
Author

FnTm commented Mar 5, 2020

@Charca the Message Tag issue forced me to update my fork to work with master. Could we maybe use this opportunity to review the possibility of merging this PR?

Or is there something more that I should do before this is ready?

As I've mentioned above - I've been running this in my (tiny) production for ~2 years now without any issues.

@Charca
Copy link
Owner

Charca commented Mar 7, 2020

Hey @FnTm, apologies for the huge delay. As I mentioned in other issues and PRs, I'm not actively working on this project and have not worked with Messenger bots in a while.

This PR looks good to me and I think we can merge it. Would it be possible to add a small section in the README file with some simple instructions on how to use this new method? Thank you.

@FnTm
Copy link
Author

FnTm commented Mar 7, 2020

yes, for sure! I'll add that ASAP, and ping you for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants