Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (v4.0) #376

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Refactor (v4.0) #376

wants to merge 14 commits into from

Conversation

ChanceSD
Copy link
Owner

@ChanceSD ChanceSD commented Apr 7, 2023

This is essentially almost a full recode of the plugin.
Any plugins currently hooking into PvPManager will break due to the package changes.
Performance should be slightly better and with more features, hopefully clearing most of the current suggestions.
Should also make the code easier to work on for future updates.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

41.3% 41.3% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 29 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

42.8% 42.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

43.2% 43.2% Coverage
0.0% 0.0% Duplication

@ChanceSD ChanceSD changed the title Refactor Refactor (v4.0) Feb 3, 2024
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

24 New issues
0 Security Hotspots
43.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChanceSD ChanceSD added this to the v4.0 milestone Feb 8, 2024
@ChanceSD ChanceSD marked this pull request as draft February 22, 2024 04:42
Copy link
Contributor

deepsource-io bot commented Mar 26, 2024

Here's the code health analysis summary for commits f60224e..7a4d549. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava❌ Failure
❗ 509 occurences introduced
🎯 561 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

sonarcloud bot commented Mar 26, 2024

@ChanceSD ChanceSD force-pushed the master-refactor branch 3 times, most recently from b287bab to 1c7089e Compare May 3, 2024 22:57
@ChanceSD ChanceSD force-pushed the master-refactor branch 6 times, most recently from 024a159 to 0393690 Compare May 15, 2024 20:43
Copy link

sonarcloud bot commented May 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant