Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new FAQ about yarn version #6796

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

jeluard
Copy link
Member

@jeluard jeluard commented May 16, 2024

Motivation

Document how to properly set default yarn version not to get issues.

@jeluard jeluard requested a review from a team as a code owner May 16, 2024 15:02
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base (c39b914) to head (e59f2c0).
Report is 26 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6796      +/-   ##
============================================
+ Coverage     61.88%   62.20%   +0.32%     
============================================
  Files           562      571       +9     
  Lines         59331    60021     +690     
  Branches       1916     1980      +64     
============================================
+ Hits          36715    37335     +620     
- Misses        22573    22643      +70     
  Partials         43       43              

docs/pages/faqs.md Outdated Show resolved Hide resolved
ensi321
ensi321 previously approved these changes May 22, 2024
Copy link
Contributor

@ensi321 ensi321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/pages/faqs.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jeluard jeluard requested a review from nflaig June 5, 2024 10:04
package.json Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
jeluard and others added 2 commits June 5, 2024 05:05
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
@jeluard jeluard requested a review from nflaig June 5, 2024 12:09
@@ -2,20 +2,6 @@

This section of the documentation will cover common questions and encounters often asked by users and developers.

## Tooling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with keeping this here as well, in addition to a proactive note in the readme.

package.json Show resolved Hide resolved
docs/pages/faqs.md Outdated Show resolved Hide resolved
docs/pages/faqs.md Outdated Show resolved Hide resolved
jeluard and others added 2 commits June 5, 2024 05:30
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
nflaig previously approved these changes Jun 5, 2024
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/pages/faqs.md Outdated Show resolved Hide resolved
@jeluard jeluard merged commit 49c1689 into ChainSafe:unstable Jun 5, 2024
18 of 20 checks passed
@jeluard jeluard deleted the jeluard/yarn-faq branch June 5, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants