chore: consolidate classic-level usage #6795
Conversation
| @@ -38,6 +38,7 @@ | |||
| "@chainsafe/ssz": "^0.15.1", | |||
| "@lodestar/config": "^1.18.1", | |||
| "@lodestar/utils": "^1.18.1", | |||
| "classic-level": "^1.4.1", | |||
There was a problem hiding this comment.
It might make sense to depend on classic-level dependency directly now that we are requiring it.
There was a problem hiding this comment.
Rather than using the level package?
There was a problem hiding this comment.
Right, the code already expect running under NodeJS and we add classic-level dependency to make sure the right version is used.
There was a problem hiding this comment.
Sounds good to me.
Can you update this PR to include that? Currently it feels like in a halfway state (which I suppose caused your comment here).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6795 +/- ##
============================================
+ Coverage 61.88% 62.21% +0.32%
============================================
Files 562 571 +9
Lines 59331 60017 +686
Branches 1916 1972 +56
============================================
+ Hits 36715 37337 +622
- Misses 22573 22637 +64
Partials 43 43 |
jeluard
changed the title
|
failing CI |
This reverts commit b439da2.
* chore: do not rely on leveldown * chore: replace level with classic-level
Motivation
Make sure
classic-levelis used consistently.Description
Remove older dependencies
levelandleveldown.dbis already dependent onclassic-level.Closes #6794