chore: upgrade classic-level #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should be able to delete the old classic-level from yarn.lock and regenerate the lockfile with the new entry. (based on |
|
@wemeetagain indeed, looks cleaner. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6793 +/- ##
=========================================
Coverage 61.88% 61.88%
=========================================
Files 562 562
Lines 59331 59331
Branches 1916 1916
=========================================
Hits 36715 36715
Misses 22573 22573
Partials 43 43 |
wemeetagain
reviewed
May 16, 2024
wemeetagain
approved these changes
May 16, 2024
matthewkeil
added a commit
that referenced
this pull request
May 29, 2024
This reverts commit a6b10df.
jeluard
added a commit
to jeluard/lodestar
that referenced
this pull request
Jun 4, 2024
* chore: upgrade classic-level * chore: address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure latest
classic-levelversion is used. It introduces changes by @matthewkeilDescription
Ran
yarn upgrade classic-level@1.4.1to use latest transitive dependency oflevel,classic-level.Note that it introduces a top-level
dependencieselement in rootpackage.json. Is that the recommended approach?