Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add paths-ignore to workflows #6713

Merged
merged 2 commits into from
Apr 26, 2024
Merged

ci: add paths-ignore to workflows #6713

merged 2 commits into from
Apr 26, 2024

Conversation

jeluard
Copy link
Member

@jeluard jeluard commented Apr 26, 2024

Motivation

Do not trigger all workflows when irrelevant files are modified (e.g. docs).

@jeluard jeluard requested a review from a team as a code owner April 26, 2024 07:58
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.87%. Comparing base (de3988d) to head (5226f91).
Report is 4 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6713   +/-   ##
=========================================
  Coverage     61.87%   61.87%           
=========================================
  Files           557      562    +5     
  Lines         59209    59301   +92     
  Branches       1915     1916    +1     
=========================================
+ Hits          36635    36695   +60     
- Misses        22531    22563   +32     
  Partials         43       43

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 1524a8a Previous: e1bc926 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 976.86 us/op 1.1203 ms/op 0.87
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 112.76 us/op 119.50 us/op 0.94
BLS verify - blst-native 1.3807 ms/op 1.3233 ms/op 1.04
BLS verifyMultipleSignatures 3 - blst-native 2.5848 ms/op 2.5253 ms/op 1.02
BLS verifyMultipleSignatures 8 - blst-native 5.5431 ms/op 5.3955 ms/op 1.03
BLS verifyMultipleSignatures 32 - blst-native 20.308 ms/op 19.586 ms/op 1.04
BLS verifyMultipleSignatures 64 - blst-native 40.202 ms/op 38.329 ms/op 1.05
BLS verifyMultipleSignatures 128 - blst-native 76.391 ms/op 76.210 ms/op 1.00
BLS deserializing 10000 signatures 889.98 ms/op 895.54 ms/op 0.99
BLS deserializing 100000 signatures 8.9159 s/op 8.9673 s/op 0.99
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3430 ms/op 1.3323 ms/op 1.01
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5067 ms/op 1.5062 ms/op 1.00
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.3216 ms/op 2.3657 ms/op 0.98
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.4232 ms/op 3.5534 ms/op 0.96
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.6197 ms/op 5.7959 ms/op 0.97
BLS aggregatePubkeys 32 - blst-native 28.882 us/op 30.095 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 112.70 us/op 113.00 us/op 1.00
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 64.715 ms/op 61.098 ms/op 1.06
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 65.618 ms/op 75.638 ms/op 0.87
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 37.985 ms/op 37.285 ms/op 1.02
getSlashingsAndExits - default max 189.60 us/op 194.55 us/op 0.97
getSlashingsAndExits - 2k 493.76 us/op 597.71 us/op 0.83
proposeBlockBody type=full, size=empty 6.3618 ms/op 6.3240 ms/op 1.01
isKnown best case - 1 super set check 491.00 ns/op 548.00 ns/op 0.90
isKnown normal case - 2 super set checks 545.00 ns/op 601.00 ns/op 0.91
isKnown worse case - 16 super set checks 406.00 ns/op 582.00 ns/op 0.70
InMemoryCheckpointStateCache - add get delete 6.6000 us/op 7.9930 us/op 0.83
validate api signedAggregateAndProof - struct 2.3966 ms/op 2.4577 ms/op 0.98
validate gossip signedAggregateAndProof - struct 2.4326 ms/op 2.4946 ms/op 0.98
validate gossip attestation - vc 640000 1.3771 ms/op 1.4302 ms/op 0.96
batch validate gossip attestation - vc 640000 - chunk 32 167.66 us/op 177.76 us/op 0.94
batch validate gossip attestation - vc 640000 - chunk 64 144.94 us/op 158.08 us/op 0.92
batch validate gossip attestation - vc 640000 - chunk 128 142.33 us/op 157.64 us/op 0.90
batch validate gossip attestation - vc 640000 - chunk 256 151.14 us/op 154.37 us/op 0.98
pickEth1Vote - no votes 1.4316 ms/op 1.4003 ms/op 1.02
pickEth1Vote - max votes 14.713 ms/op 12.469 ms/op 1.18
pickEth1Vote - Eth1Data hashTreeRoot value x2048 25.169 ms/op 22.857 ms/op 1.10
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 42.509 ms/op 32.452 ms/op 1.31
pickEth1Vote - Eth1Data fastSerialize value x2048 767.44 us/op 815.40 us/op 0.94
pickEth1Vote - Eth1Data fastSerialize tree x2048 10.791 ms/op 5.8754 ms/op 1.84
bytes32 toHexString 908.00 ns/op 895.00 ns/op 1.01
bytes32 Buffer.toString(hex) 378.00 ns/op 323.00 ns/op 1.17
bytes32 Buffer.toString(hex) from Uint8Array 562.00 ns/op 589.00 ns/op 0.95
bytes32 Buffer.toString(hex) + 0x 332.00 ns/op 343.00 ns/op 0.97
Object access 1 prop 0.25300 ns/op 0.22600 ns/op 1.12
Map access 1 prop 0.18500 ns/op 0.17200 ns/op 1.08
Object get x1000 8.5210 ns/op 8.5980 ns/op 0.99
Map get x1000 0.95900 ns/op 0.93100 ns/op 1.03
Object set x1000 66.497 ns/op 73.009 ns/op 0.91
Map set x1000 52.043 ns/op 56.855 ns/op 0.92
Return object 10000 times 0.27230 ns/op 0.25730 ns/op 1.06
Throw Error 10000 times 4.3408 us/op 4.0551 us/op 1.07
fastMsgIdFn sha256 / 200 bytes 3.7390 us/op 3.5930 us/op 1.04
fastMsgIdFn h32 xxhash / 200 bytes 383.00 ns/op 361.00 ns/op 1.06
fastMsgIdFn h64 xxhash / 200 bytes 434.00 ns/op 442.00 ns/op 0.98
fastMsgIdFn sha256 / 1000 bytes 12.760 us/op 12.038 us/op 1.06
fastMsgIdFn h32 xxhash / 1000 bytes 535.00 ns/op 503.00 ns/op 1.06
fastMsgIdFn h64 xxhash / 1000 bytes 492.00 ns/op 513.00 ns/op 0.96
fastMsgIdFn sha256 / 10000 bytes 117.48 us/op 106.31 us/op 1.11
fastMsgIdFn h32 xxhash / 10000 bytes 2.2070 us/op 2.0500 us/op 1.08
fastMsgIdFn h64 xxhash / 10000 bytes 1.5470 us/op 1.4510 us/op 1.07
send data - 1000 256B messages 23.352 ms/op 26.444 ms/op 0.88
send data - 1000 512B messages 30.222 ms/op 27.568 ms/op 1.10
send data - 1000 1024B messages 46.889 ms/op 47.254 ms/op 0.99
send data - 1000 1200B messages 44.577 ms/op 46.171 ms/op 0.97
send data - 1000 2048B messages 52.815 ms/op 53.782 ms/op 0.98
send data - 1000 4096B messages 51.707 ms/op 46.971 ms/op 1.10
send data - 1000 16384B messages 118.68 ms/op 121.17 ms/op 0.98
send data - 1000 65536B messages 531.46 ms/op 485.87 ms/op 1.09
enrSubnets - fastDeserialize 64 bits 1.7960 us/op 1.2720 us/op 1.41
enrSubnets - ssz BitVector 64 bits 577.00 ns/op 443.00 ns/op 1.30
enrSubnets - fastDeserialize 4 bits 248.00 ns/op 176.00 ns/op 1.41
enrSubnets - ssz BitVector 4 bits 547.00 ns/op 451.00 ns/op 1.21
prioritizePeers score -10:0 att 32-0.1 sync 2-0 242.81 us/op 235.82 us/op 1.03
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 339.14 us/op 299.39 us/op 1.13
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 409.55 us/op 398.78 us/op 1.03
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 674.04 us/op 624.14 us/op 1.08
prioritizePeers score 0:0 att 64-1 sync 4-1 840.76 us/op 730.21 us/op 1.15
array of 16000 items push then shift 1.8169 us/op 1.6789 us/op 1.08
LinkedList of 16000 items push then shift 9.7500 ns/op 9.5980 ns/op 1.02
array of 16000 items push then pop 113.26 ns/op 110.00 ns/op 1.03
LinkedList of 16000 items push then pop 9.4000 ns/op 9.0450 ns/op 1.04
array of 24000 items push then shift 2.6473 us/op 2.5623 us/op 1.03
LinkedList of 24000 items push then shift 9.4260 ns/op 9.6570 ns/op 0.98
array of 24000 items push then pop 157.17 ns/op 154.00 ns/op 1.02
LinkedList of 24000 items push then pop 9.5530 ns/op 8.7710 ns/op 1.09
intersect bitArray bitLen 8 6.4460 ns/op 5.8720 ns/op 1.10
intersect array and set length 8 70.402 ns/op 63.452 ns/op 1.11
intersect bitArray bitLen 128 36.460 ns/op 35.642 ns/op 1.02
intersect array and set length 128 1.0749 us/op 878.53 ns/op 1.22
bitArray.getTrueBitIndexes() bitLen 128 1.7050 us/op 1.5660 us/op 1.09
bitArray.getTrueBitIndexes() bitLen 248 2.8180 us/op 2.7460 us/op 1.03
bitArray.getTrueBitIndexes() bitLen 512 5.9860 us/op 6.0810 us/op 0.98
Buffer.concat 32 items 1.0540 us/op 1.0560 us/op 1.00
Uint8Array.set 32 items 1.9430 us/op 1.9290 us/op 1.01
Set add up to 64 items then delete first 4.9484 us/op 4.9368 us/op 1.00
OrderedSet add up to 64 items then delete first 6.5278 us/op 6.7410 us/op 0.97
Set add up to 64 items then delete last 5.4146 us/op 5.2878 us/op 1.02
OrderedSet add up to 64 items then delete last 6.8226 us/op 6.0619 us/op 1.13
Set add up to 64 items then delete middle 5.3160 us/op 4.9312 us/op 1.08
OrderedSet add up to 64 items then delete middle 8.2303 us/op 7.5483 us/op 1.09
Set add up to 128 items then delete first 11.117 us/op 10.489 us/op 1.06
OrderedSet add up to 128 items then delete first 13.920 us/op 14.393 us/op 0.97
Set add up to 128 items then delete last 10.364 us/op 10.833 us/op 0.96
OrderedSet add up to 128 items then delete last 13.411 us/op 12.191 us/op 1.10
Set add up to 128 items then delete middle 10.462 us/op 9.3318 us/op 1.12
OrderedSet add up to 128 items then delete middle 19.813 us/op 18.877 us/op 1.05
Set add up to 256 items then delete first 21.904 us/op 19.332 us/op 1.13
OrderedSet add up to 256 items then delete first 29.815 us/op 25.585 us/op 1.17
Set add up to 256 items then delete last 20.563 us/op 21.456 us/op 0.96
OrderedSet add up to 256 items then delete last 27.191 us/op 24.659 us/op 1.10
Set add up to 256 items then delete middle 20.735 us/op 19.801 us/op 1.05
OrderedSet add up to 256 items then delete middle 50.876 us/op 49.481 us/op 1.03
transfer serialized Status (84 B) 2.0450 us/op 1.8620 us/op 1.10
copy serialized Status (84 B) 1.5170 us/op 1.4580 us/op 1.04
transfer serialized SignedVoluntaryExit (112 B) 2.2890 us/op 1.9770 us/op 1.16
copy serialized SignedVoluntaryExit (112 B) 1.6720 us/op 1.4170 us/op 1.18
transfer serialized ProposerSlashing (416 B) 3.3390 us/op 2.1420 us/op 1.56
copy serialized ProposerSlashing (416 B) 2.9210 us/op 2.0090 us/op 1.45
transfer serialized Attestation (485 B) 3.5030 us/op 2.4450 us/op 1.43
copy serialized Attestation (485 B) 2.9280 us/op 2.0360 us/op 1.44
transfer serialized AttesterSlashing (33232 B) 3.2920 us/op 2.2340 us/op 1.47
copy serialized AttesterSlashing (33232 B) 7.1670 us/op 7.8520 us/op 0.91
transfer serialized Small SignedBeaconBlock (128000 B) 3.5280 us/op 2.6490 us/op 1.33
copy serialized Small SignedBeaconBlock (128000 B) 19.792 us/op 21.836 us/op 0.91
transfer serialized Avg SignedBeaconBlock (200000 B) 4.0370 us/op 3.5300 us/op 1.14
copy serialized Avg SignedBeaconBlock (200000 B) 26.008 us/op 31.074 us/op 0.84
transfer serialized BlobsSidecar (524380 B) 4.0650 us/op 3.7080 us/op 1.10
copy serialized BlobsSidecar (524380 B) 88.952 us/op 120.87 us/op 0.74
transfer serialized Big SignedBeaconBlock (1000000 B) 3.9730 us/op 4.2850 us/op 0.93
copy serialized Big SignedBeaconBlock (1000000 B) 416.31 us/op 181.91 us/op 2.29
pass gossip attestations to forkchoice per slot 4.1604 ms/op 4.7392 ms/op 0.88
forkChoice updateHead vc 100000 bc 64 eq 0 728.64 us/op 756.99 us/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 0 5.1392 ms/op 6.9367 ms/op 0.74
forkChoice updateHead vc 1000000 bc 64 eq 0 7.7843 ms/op 7.8579 ms/op 0.99
forkChoice updateHead vc 600000 bc 320 eq 0 4.6425 ms/op 4.4736 ms/op 1.04
forkChoice updateHead vc 600000 bc 1200 eq 0 4.9636 ms/op 4.5946 ms/op 1.08
forkChoice updateHead vc 600000 bc 7200 eq 0 6.3824 ms/op 5.8008 ms/op 1.10
forkChoice updateHead vc 600000 bc 64 eq 1000 12.303 ms/op 11.646 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 10000 13.106 ms/op 13.484 ms/op 0.97
forkChoice updateHead vc 600000 bc 64 eq 300000 18.103 ms/op 22.424 ms/op 0.81
computeDeltas 500000 validators 300 proto nodes 7.3195 ms/op 7.6478 ms/op 0.96
computeDeltas 500000 validators 1200 proto nodes 7.0014 ms/op 7.0795 ms/op 0.99
computeDeltas 500000 validators 7200 proto nodes 6.5310 ms/op 6.8581 ms/op 0.95
computeDeltas 750000 validators 300 proto nodes 9.8606 ms/op 10.019 ms/op 0.98
computeDeltas 750000 validators 1200 proto nodes 9.7399 ms/op 9.9164 ms/op 0.98
computeDeltas 750000 validators 7200 proto nodes 9.9198 ms/op 9.9342 ms/op 1.00
computeDeltas 1400000 validators 300 proto nodes 19.355 ms/op 18.558 ms/op 1.04
computeDeltas 1400000 validators 1200 proto nodes 19.059 ms/op 19.851 ms/op 0.96
computeDeltas 1400000 validators 7200 proto nodes 19.672 ms/op 20.013 ms/op 0.98
computeDeltas 2100000 validators 300 proto nodes 28.779 ms/op 28.851 ms/op 1.00
computeDeltas 2100000 validators 1200 proto nodes 28.951 ms/op 29.614 ms/op 0.98
computeDeltas 2100000 validators 7200 proto nodes 28.552 ms/op 28.543 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 2.2354 ms/op 2.7828 ms/op 0.80
altair processAttestation - 250000 vs - 7PWei worstcase 3.1543 ms/op 4.5102 ms/op 0.70
altair processAttestation - setStatus - 1/6 committees join 146.91 us/op 208.66 us/op 0.70
altair processAttestation - setStatus - 1/3 committees join 299.79 us/op 399.80 us/op 0.75
altair processAttestation - setStatus - 1/2 committees join 400.86 us/op 502.51 us/op 0.80
altair processAttestation - setStatus - 2/3 committees join 493.50 us/op 649.02 us/op 0.76
altair processAttestation - setStatus - 4/5 committees join 698.00 us/op 866.44 us/op 0.81
altair processAttestation - setStatus - 100% committees join 822.35 us/op 1.0783 ms/op 0.76
altair processBlock - 250000 vs - 7PWei normalcase 9.0079 ms/op 8.9681 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase hashState 33.852 ms/op 36.494 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase 44.097 ms/op 47.454 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase hashState 97.074 ms/op 94.505 ms/op 1.03
phase0 processBlock - 250000 vs - 7PWei normalcase 2.5187 ms/op 2.7337 ms/op 0.92
phase0 processBlock - 250000 vs - 7PWei worstcase 30.162 ms/op 32.340 ms/op 0.93
altair processEth1Data - 250000 vs - 7PWei normalcase 512.80 us/op 573.83 us/op 0.89
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.818 us/op 17.466 us/op 0.79
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 52.190 us/op 83.299 us/op 0.63
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 13.269 us/op 24.354 us/op 0.54
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 15.143 us/op 18.497 us/op 0.82
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 206.95 us/op 272.20 us/op 0.76
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.3902 ms/op 1.8580 ms/op 0.75
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.7950 ms/op 2.2505 ms/op 0.80
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.7386 ms/op 2.5309 ms/op 0.69
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4938 ms/op 3.8619 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.6281 ms/op 3.0729 ms/op 0.86
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.3378 ms/op 6.4759 ms/op 0.98
Tree 40 250000 create 391.88 ms/op 693.74 ms/op 0.56
Tree 40 250000 get(125000) 214.71 ns/op 223.97 ns/op 0.96
Tree 40 250000 set(125000) 1.0841 us/op 1.2973 us/op 0.84
Tree 40 250000 toArray() 24.058 ms/op 23.771 ms/op 1.01
Tree 40 250000 iterate all - toArray() + loop 23.701 ms/op 24.888 ms/op 0.95
Tree 40 250000 iterate all - get(i) 79.667 ms/op 82.777 ms/op 0.96
MutableVector 250000 create 13.656 ms/op 19.502 ms/op 0.70
MutableVector 250000 get(125000) 7.4660 ns/op 7.0760 ns/op 1.06
MutableVector 250000 set(125000) 300.06 ns/op 336.60 ns/op 0.89
MutableVector 250000 toArray() 3.9320 ms/op 3.8228 ms/op 1.03
MutableVector 250000 iterate all - toArray() + loop 4.0133 ms/op 4.1505 ms/op 0.97
MutableVector 250000 iterate all - get(i) 1.5871 ms/op 1.7203 ms/op 0.92
Array 250000 create 3.4574 ms/op 3.8479 ms/op 0.90
Array 250000 clone - spread 1.2752 ms/op 1.5510 ms/op 0.82
Array 250000 get(125000) 1.1180 ns/op 1.3250 ns/op 0.84
Array 250000 set(125000) 4.6210 ns/op 4.8440 ns/op 0.95
Array 250000 iterate all - loop 174.58 us/op 170.22 us/op 1.03
effectiveBalanceIncrements clone Uint8Array 300000 38.434 us/op 42.643 us/op 0.90
effectiveBalanceIncrements clone MutableVector 300000 354.00 ns/op 463.00 ns/op 0.76
effectiveBalanceIncrements rw all Uint8Array 300000 206.20 us/op 209.49 us/op 0.98
effectiveBalanceIncrements rw all MutableVector 300000 96.637 ms/op 102.29 ms/op 0.94
phase0 afterProcessEpoch - 250000 vs - 7PWei 126.41 ms/op 121.75 ms/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 59.558 ms/op 62.490 ms/op 0.95
altair processEpoch - mainnet_e81889 512.63 ms/op 525.15 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 87.540 ms/op 88.546 ms/op 0.99
mainnet_e81889 - altair processJustificationAndFinalization 21.563 us/op 17.258 us/op 1.25
mainnet_e81889 - altair processInactivityUpdates 6.2357 ms/op 5.9194 ms/op 1.05
mainnet_e81889 - altair processRewardsAndPenalties 58.502 ms/op 86.144 ms/op 0.68
mainnet_e81889 - altair processRegistryUpdates 2.4310 us/op 2.4490 us/op 0.99
mainnet_e81889 - altair processSlashings 589.00 ns/op 583.00 ns/op 1.01
mainnet_e81889 - altair processEth1DataReset 1.1270 us/op 472.00 ns/op 2.39
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.4172 ms/op 1.5867 ms/op 0.89
mainnet_e81889 - altair processSlashingsReset 5.3400 us/op 4.0850 us/op 1.31
mainnet_e81889 - altair processRandaoMixesReset 7.3450 us/op 7.2810 us/op 1.01
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0040 us/op 749.00 ns/op 1.34
mainnet_e81889 - altair processParticipationFlagUpdates 3.8240 us/op 1.6460 us/op 2.32
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1200 us/op 777.00 ns/op 1.44
mainnet_e81889 - altair afterProcessEpoch 132.83 ms/op 121.79 ms/op 1.09
capella processEpoch - mainnet_e217614 2.4786 s/op 2.4277 s/op 1.02
mainnet_e217614 - capella beforeProcessEpoch 487.42 ms/op 498.83 ms/op 0.98
mainnet_e217614 - capella processJustificationAndFinalization 16.099 us/op 17.702 us/op 0.91
mainnet_e217614 - capella processInactivityUpdates 17.689 ms/op 22.341 ms/op 0.79
mainnet_e217614 - capella processRewardsAndPenalties 541.08 ms/op 559.97 ms/op 0.97
mainnet_e217614 - capella processRegistryUpdates 18.592 us/op 21.769 us/op 0.85
mainnet_e217614 - capella processSlashings 480.00 ns/op 553.00 ns/op 0.87
mainnet_e217614 - capella processEth1DataReset 420.00 ns/op 516.00 ns/op 0.81
mainnet_e217614 - capella processEffectiveBalanceUpdates 11.286 ms/op 7.9661 ms/op 1.42
mainnet_e217614 - capella processSlashingsReset 3.5010 us/op 3.4460 us/op 1.02
mainnet_e217614 - capella processRandaoMixesReset 4.7200 us/op 4.2390 us/op 1.11
mainnet_e217614 - capella processHistoricalRootsUpdate 420.00 ns/op 670.00 ns/op 0.63
mainnet_e217614 - capella processParticipationFlagUpdates 1.5350 us/op 1.4250 us/op 1.08
mainnet_e217614 - capella afterProcessEpoch 362.06 ms/op 316.89 ms/op 1.14
phase0 processEpoch - mainnet_e58758 519.69 ms/op 521.49 ms/op 1.00
mainnet_e58758 - phase0 beforeProcessEpoch 156.23 ms/op 134.71 ms/op 1.16
mainnet_e58758 - phase0 processJustificationAndFinalization 17.732 us/op 16.007 us/op 1.11
mainnet_e58758 - phase0 processRewardsAndPenalties 49.027 ms/op 69.606 ms/op 0.70
mainnet_e58758 - phase0 processRegistryUpdates 14.382 us/op 14.387 us/op 1.00
mainnet_e58758 - phase0 processSlashings 490.00 ns/op 767.00 ns/op 0.64
mainnet_e58758 - phase0 processEth1DataReset 453.00 ns/op 556.00 ns/op 0.81
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0789 ms/op 1.3065 ms/op 0.83
mainnet_e58758 - phase0 processSlashingsReset 3.0490 us/op 3.9930 us/op 0.76
mainnet_e58758 - phase0 processRandaoMixesReset 4.3420 us/op 7.6160 us/op 0.57
mainnet_e58758 - phase0 processHistoricalRootsUpdate 631.00 ns/op 954.00 ns/op 0.66
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9660 us/op 4.8770 us/op 0.81
mainnet_e58758 - phase0 afterProcessEpoch 105.50 ms/op 102.16 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3789 ms/op 1.9390 ms/op 0.71
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.1381 ms/op 1.5096 ms/op 1.42
altair processInactivityUpdates - 250000 normalcase 22.745 ms/op 34.890 ms/op 0.65
altair processInactivityUpdates - 250000 worstcase 22.217 ms/op 29.297 ms/op 0.76
phase0 processRegistryUpdates - 250000 normalcase 10.291 us/op 13.274 us/op 0.78
phase0 processRegistryUpdates - 250000 badcase_full_deposits 435.26 us/op 496.81 us/op 0.88
phase0 processRegistryUpdates - 250000 worstcase 0.5 152.41 ms/op 154.90 ms/op 0.98
altair processRewardsAndPenalties - 250000 normalcase 66.872 ms/op 93.881 ms/op 0.71
altair processRewardsAndPenalties - 250000 worstcase 54.849 ms/op 69.186 ms/op 0.79
phase0 getAttestationDeltas - 250000 normalcase 9.5405 ms/op 9.9947 ms/op 0.95
phase0 getAttestationDeltas - 250000 worstcase 10.101 ms/op 9.8642 ms/op 1.02
phase0 processSlashings - 250000 worstcase 95.908 us/op 94.494 us/op 1.01
altair processSyncCommitteeUpdates - 250000 159.01 ms/op 171.20 ms/op 0.93
BeaconState.hashTreeRoot - No change 460.00 ns/op 735.00 ns/op 0.63
BeaconState.hashTreeRoot - 1 full validator 135.29 us/op 178.67 us/op 0.76
BeaconState.hashTreeRoot - 32 full validator 1.8372 ms/op 1.5230 ms/op 1.21
BeaconState.hashTreeRoot - 512 full validator 19.806 ms/op 16.386 ms/op 1.21
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 202.58 us/op 180.11 us/op 1.12
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2414 ms/op 2.5968 ms/op 0.86
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 34.340 ms/op 35.223 ms/op 0.97
BeaconState.hashTreeRoot - 1 balances 140.08 us/op 165.92 us/op 0.84
BeaconState.hashTreeRoot - 32 balances 1.2582 ms/op 1.5656 ms/op 0.80
BeaconState.hashTreeRoot - 512 balances 10.428 ms/op 14.922 ms/op 0.70
BeaconState.hashTreeRoot - 250000 balances 196.85 ms/op 226.61 ms/op 0.87
aggregationBits - 2048 els - zipIndexesInBitList 28.236 us/op 32.563 us/op 0.87
byteArrayEquals 32 77.105 ns/op 84.114 ns/op 0.92
Buffer.compare 32 56.977 ns/op 59.203 ns/op 0.96
byteArrayEquals 1024 2.1129 us/op 2.1418 us/op 0.99
Buffer.compare 1024 74.224 ns/op 71.892 ns/op 1.03
byteArrayEquals 16384 33.942 us/op 34.669 us/op 0.98
Buffer.compare 16384 280.31 ns/op 263.80 ns/op 1.06
byteArrayEquals 123687377 252.92 ms/op 271.47 ms/op 0.93
Buffer.compare 123687377 6.8474 ms/op 10.845 ms/op 0.63
byteArrayEquals 32 - diff last byte 77.675 ns/op 76.029 ns/op 1.02
Buffer.compare 32 - diff last byte 58.714 ns/op 59.018 ns/op 0.99
byteArrayEquals 1024 - diff last byte 2.0539 us/op 2.3970 us/op 0.86
Buffer.compare 1024 - diff last byte 73.371 ns/op 74.676 ns/op 0.98
byteArrayEquals 16384 - diff last byte 32.865 us/op 34.415 us/op 0.95
Buffer.compare 16384 - diff last byte 281.70 ns/op 290.66 ns/op 0.97
byteArrayEquals 123687377 - diff last byte 255.76 ms/op 283.27 ms/op 0.90
Buffer.compare 123687377 - diff last byte 7.0136 ms/op 9.0192 ms/op 0.78
byteArrayEquals 32 - random bytes 5.4310 ns/op 6.5690 ns/op 0.83
Buffer.compare 32 - random bytes 61.724 ns/op 64.829 ns/op 0.95
byteArrayEquals 1024 - random bytes 5.2280 ns/op 6.6690 ns/op 0.78
Buffer.compare 1024 - random bytes 60.413 ns/op 64.668 ns/op 0.93
byteArrayEquals 16384 - random bytes 5.2140 ns/op 6.7320 ns/op 0.77
Buffer.compare 16384 - random bytes 60.501 ns/op 65.066 ns/op 0.93
byteArrayEquals 123687377 - random bytes 8.3700 ns/op 10.910 ns/op 0.77
Buffer.compare 123687377 - random bytes 63.870 ns/op 74.600 ns/op 0.86
regular array get 100000 times 45.435 us/op 47.009 us/op 0.97
wrappedArray get 100000 times 44.704 us/op 46.996 us/op 0.95
arrayWithProxy get 100000 times 14.750 ms/op 14.800 ms/op 1.00
ssz.Root.equals 53.539 ns/op 55.693 ns/op 0.96
byteArrayEquals 52.872 ns/op 56.502 ns/op 0.94
Buffer.compare 10.775 ns/op 13.024 ns/op 0.83
shuffle list - 16384 els 8.6716 ms/op 9.6550 ms/op 0.90
shuffle list - 250000 els 127.71 ms/op 131.52 ms/op 0.97
processSlot - 1 slots 16.847 us/op 19.910 us/op 0.85
processSlot - 32 slots 3.7941 ms/op 3.5677 ms/op 1.06
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 57.578 ms/op 69.698 ms/op 0.83
getCommitteeAssignments - req 1 vs - 250000 vc 2.7748 ms/op 2.9163 ms/op 0.95
getCommitteeAssignments - req 100 vs - 250000 vc 4.0365 ms/op 4.1051 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3583 ms/op 4.5100 ms/op 0.97
findModifiedValidators - 10000 modified validators 423.55 ms/op 415.09 ms/op 1.02
findModifiedValidators - 1000 modified validators 260.45 ms/op 239.76 ms/op 1.09
findModifiedValidators - 100 modified validators 250.54 ms/op 302.08 ms/op 0.83
findModifiedValidators - 10 modified validators 271.70 ms/op 277.77 ms/op 0.98
findModifiedValidators - 1 modified validators 273.30 ms/op 263.35 ms/op 1.04
findModifiedValidators - no difference 265.84 ms/op 332.13 ms/op 0.80
compare ViewDUs 5.0163 s/op 5.8522 s/op 0.86
compare each validator Uint8Array 1.6674 s/op 1.6977 s/op 0.98
compare ViewDU to Uint8Array 1.1450 s/op 1.5546 s/op 0.74
migrate state 1000000 validators, 24 modified, 0 new 777.68 ms/op 995.02 ms/op 0.78
migrate state 1000000 validators, 1700 modified, 1000 new 1.1801 s/op 1.3296 s/op 0.89
migrate state 1000000 validators, 3400 modified, 2000 new 1.5403 s/op 1.6944 s/op 0.91
migrate state 1500000 validators, 24 modified, 0 new 797.92 ms/op 954.89 ms/op 0.84
migrate state 1500000 validators, 1700 modified, 1000 new 1.2112 s/op 1.4351 s/op 0.84
migrate state 1500000 validators, 3400 modified, 2000 new 1.6256 s/op 1.7685 s/op 0.92
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.9200 ns/op 5.0300 ns/op 0.98
state getBlockRootAtSlot - 250000 vs - 7PWei 849.41 ns/op 784.93 ns/op 1.08
computeProposers - vc 250000 11.115 ms/op 10.264 ms/op 1.08
computeEpochShuffling - vc 250000 136.56 ms/op 133.83 ms/op 1.02
getNextSyncCommittee - vc 250000 160.90 ms/op 174.24 ms/op 0.92
computeSigningRoot for AttestationData 28.098 us/op 29.321 us/op 0.96
hash AttestationData serialized data then Buffer.toString(base64) 2.4639 us/op 2.5152 us/op 0.98
toHexString serialized data 1.2249 us/op 1.3027 us/op 0.94
Buffer.toString(base64) 267.22 ns/op 248.10 ns/op 1.08

by benchmarkbot/action

nflaig
nflaig reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might wanna come to a conclusion first in #6686 if we wanna use labels or ignore certain folders. Some requirements like skipping spec tests for certain PRs will be hard to achieve with this strategy.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/benchmark.yml Outdated Show resolved Hide resolved
@jeluard
Copy link
Member Author

jeluard commented Apr 26, 2024

@nflaig right, my understanding from #6686 was that both approaches (label to skip checks and folder based skip) were complimentary. I don't see any shortcomings with skipping tests for docs, at least with the current workflows.

@nflaig
Copy link
Member

nflaig commented Apr 26, 2024

@nflaig right, my understanding from #6686 was that both approaches (label to skip checks and folder based skip) were complimentary. I don't see any shortcomings with skipping tests for docs, at least with the current workflows.

We can definitely combine both approaches, but the question is if path based ignore is even required if we go with labels.

If we go with this please make sure we are not skipping workflows that shouldn't be skipped.

@jeluard
Copy link
Member Author

jeluard commented Apr 26, 2024

We can definitely combine both approaches, but the question is if path based ignore is even required if we go with labels.

Some folders never require things like tests, so sounds like the best option for them. IMO labels should be the exception, and only used with caution. You don't want not to test when needed. Similarly, I'd rather not have to use them when it's known in advance that tests are irrelevant for those changes (e.g. for docs/**)

If we go with this please make sure we are not skipping workflows that shouldn't be skipped.

Sure yeah, that's why I went with the conservative approach of just ignoring docs/** and dashboards/**.

@nflaig nflaig changed the title chore: added paths-ignore ci: add paths-ignore to workflows Apr 26, 2024
@jeluard jeluard merged commit e460bb1 into unstable Apr 26, 2024
19 of 21 checks passed
@jeluard jeluard deleted the jeluard/add-paths-ignore branch April 26, 2024 17:22
nflaig added a commit that referenced this pull request May 3, 2024
@nflaig
Revert "ci: add paths-ignore to workflows (#6713)"
bbe6bf2 
This reverts commit e460bb1.
@nflaig nflaig mentioned this pull request May 3, 2024
Merged
nflaig added a commit that referenced this pull request May 3, 2024
@nflaig
chore: revert "ci: add paths-ignore to workflows (#6713)" (#6730)
dbde1cb 
Revert "ci: add paths-ignore to workflows (#6713)"

This reverts commit e460bb1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeluard @nflaig