New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added docker support for osx #6696
Open
jeluard
wants to merge
2
commits into
unstable
Choose a base branch
from
jeluard/compose-local-dev
base: unstable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
commented
Apr 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6696 +/- ##
=========================================
Coverage 61.87% 61.87%
=========================================
Files 562 562
Lines 59301 59301
Branches 1916 1916
=========================================
Hits 36695 36695
Misses 22563 22563
Partials 43 43 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Apr 23, 2024
volumes: | ||
- "prometheus:/prometheus" | ||
extra_hosts: | ||
- "host.docker.internal:host-gateway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should do, same approach we use in sim tests #5940
jeluard
force-pushed
the
jeluard/compose-local-dev
branch
from
April 29, 2024 20:34
58773be
to
da6ec66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Supports MacOS out of the box by not relying on
network_mode: host
.host.docker.internal
is used instead, which works on all platform.Tested on
MacOS
andubuntu