chore: remove got dependency #6497

HiroyukiNaito · 2024-02-28T12:38:12Z

Motivation

For the solution of #6488

Description

Changed all codes which use got to fetch module.
Closes # #6488

Steps to test or reproduce

yarn build
yarn test:unit

CLAassistant · 2024-02-28T12:38:18Z

All committers have signed the CLA.

jeluard

I don't see any changes to yarn.lock ?
The correct way to remove a dependency is to use the yarn remove command.

packages/cli/src/util/file.ts

packages/cli/test/utils/simulation/execution_clients/geth.ts

packages/state-transition/test/utils/testFileCache.ts

packages/cli/src/util/file.ts

packages/cli/test/utils/simulation/beacon_clients/lighthouse.ts

packages/cli/test/utils/simulation/beacon_clients/lodestar.ts

packages/cli/src/networks/index.ts

nflaig · 2024-02-28T18:38:27Z

The correct way to remove a dependency is to use the yarn remove command.

@jeluard is there a difference between that and just removing it from package.json + running yarn install afterwards?

jeluard · 2024-02-28T20:29:09Z

The correct way to remove a dependency is to use the yarn remove command.

@jeluard is there a difference between that and just removing it from package.json + running yarn install afterwards?

Probably not, somehow it feels safer to use yarn remove :)

Co-authored-by: Julien <jeluard@users.noreply.github.com>

HiroyukiNaito · 2024-02-29T07:57:20Z

The correct way to remove a dependency is to use the yarn remove command.

@jeluard is there a difference between that and just removing it from package.json + running yarn install afterwards?

Probably not, somehow it feels safer to use yarn remove :)

Sorry, should delete by yarn remove

…omise<void>

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

packages/cli/src/util/file.ts

packages/cli/test/utils/simulation/beacon_clients/lodestar.ts

packages/cli/src/networks/index.ts

packages/cli/test/utils/simulation/beacon_clients/lighthouse.ts

nflaig

Please make sure to verify locally that your changes at least build and there are no lint issues

At a minimum run

yarn build (or yarn check-types)
and yarn lint

HiroyukiNaito · 2024-03-01T11:14:39Z

Remaining task

Importing @lodestar/api for wrapedFetch function
Delete following codes

 if (err instanceof FetchError && err.code !== "ECONNREFUSED") {
            return {ok: true};
          }

Unility function for fetch of POST requests (using wrapedFetch)
Error handing of fetchBootnode
- Simulate the error dev node for it by passing --network flag. Reference PR chore: update url of goerli bootnodes file and genesis ssz #6279

4XX-5XX Error

Error: Error fetching bootnodes file: Status Code 404 (Not Found)
    at fetchBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:116:11)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at getNetworkBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:128:24)
    at beaconHandlerInit (file:///home/hnaito/lodestar/packages/cli/src/cmds/beacon/handler.ts:179:35)

Other error

Error fetching latest bootnodes: FetchError: Request to https://example-example-example.com/notfound failed, reason: getaddrinfo ENOTFOUND example-example-example.com
    at wrappedFetch (file:///home/hnaito/lodestar/packages/api/src/utils/client/fetch.ts:12:11)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at fetchBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:114:15)
    at getNetworkBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:128:24)
    at beaconHandlerInit (file:///home/hnaito/lodestar/packages/cli/src/cmds/beacon/handler.ts:179:35)
    at Object.beaconHandler [as handler] (file:///home/hnaito/lodestar/packages/cli/src/cmds/beacon/handler.ts:36:84)

@nflaig So far, pointed codes are corrected. However, you mentioned the nested Error still Nesting by FetchError.
https://github.com/ChainSafe/lodestar/pull/6497/files#diff-e138e8a415f1771c2089d8cf11a0ec52cb3c345e163e9b7573fc0284c342b4a1R130

HiroyukiNaito · 2024-03-01T17:47:45Z

packages/cli/test/utils/simulation/utils/network.ts

@jeluard I coded in network.ts as a utility function by wrapedFetch.

codecov · 2024-03-02T14:40:40Z

Codecov Report

Merging #6497 (e90a890) into unstable (6675739) will decrease coverage by 0.01%.
Report is 4 commits behind head on unstable.
The diff coverage is 22.22%.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #6497      +/-   ##
============================================
- Coverage     61.72%   61.71%   -0.01%     
============================================
  Files           555      555              
  Lines         58204    58217      +13     
  Branches       1843     1844       +1     
============================================
+ Hits          35926    35931       +5     
- Misses        22239    22247       +8     
  Partials         39       39

HiroyukiNaito · 2024-03-02T14:46:56Z

packages/cli/src/networks/index.ts

@@ -102,13 +101,20 @@ export function getGenesisFileUrl(network: NetworkName): string | null {
 * Fetches the latest list of bootnodes for a network
 * Bootnodes file is expected to contain bootnode ENR's concatenated by newlines
 */
-export async function fetchBootnodes(network: NetworkName): Promise<string[]> {
+
+class FetchBootFileError extends Error {}


Should I move the CustomError to the file?

lodestar/packages/utils/src/errors.ts

Line 13 in b5712a6

export class LodestarError<T extends {code: string}> extends Error {

HiroyukiNaito · 2024-03-03T05:31:04Z

packages/cli/src/networks/index.ts

@@ -121,8 +127,13 @@ export async function getNetworkBootnodes(network: NetworkName): Promise<string[
      const bootEnrs = await fetchBootnodes(network);
      bootnodes.push(...bootEnrs);
    } catch (e) {
-      // eslint-disable-next-line no-console
-      console.error(`Error fetching latest bootnodes: ${(e as Error).stack}`);
+      if (e instanceof FetchBootFileError) {


If I added the logic, the nested Error mesage resolved.

Suggested change

if (e instanceof FetchBootFileError) {

if (e instanceof FetchBootFileError) {

// eslint-disable-next-line no-console

console.error(`${(e as Error).stack}`);

}

if (e instanceof FetchError) {

console.error(`${(e as Error).stack}`);

}

The message becomes

FetchError: Request to https://example-example-example.com/notfound failed, reason: getaddrinfo ENOTFOUND example-example-example.com at wrappedFetch (file:///home/hnaito/lodestar/packages/api/src/utils/client/fetch.ts:12:11) at processTicksAndRejections (node:internal/process/task_queues:95:5) at fetchBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:114:15) at getNetworkBootnodes (file:///home/hnaito/lodestar/packages/cli/src/networks/index.ts:128:24) at beaconHandlerInit (file:///home/hnaito/lodestar/packages/cli/src/cmds/beacon/handler.ts:179:35) at Object.beaconHandler [as handler] (file:///home/hnaito/lodestar/packages/cli/src/cmds/beacon/handler.ts:36:84)

HiroyukiNaito added 4 commits February 28, 2024 18:30

Changed got to fetch in file.ts

bb7bb0b

Align the valuable name

d34d763

Completed changing module got to fetch in file.ts

492f12a

Changed All files got to fetch

357c37a

HiroyukiNaito requested a review from a team as a code owner February 28, 2024 12:38

HiroyukiNaito changed the title ~~Remove got dependency #6866~~ fix: Remove got dependency #6866 Feb 28, 2024

HiroyukiNaito changed the title ~~fix: Remove got dependency #6866~~ fix: remove got dependency #6866 Feb 28, 2024

jeluard requested changes Feb 28, 2024

View reviewed changes

nflaig reviewed Feb 28, 2024

View reviewed changes

nflaig mentioned this pull request Feb 28, 2024

chore: add eslint rule to restrict global fetch #6500

Merged

HiroyukiNaito and others added 3 commits February 29, 2024 16:39

Update packages/cli/src/util/file.ts

ca99c0c

Co-authored-by: Julien <jeluard@users.noreply.github.com>

Update packages/cli/src/util/file.ts

883fca8

Co-authored-by: Julien <jeluard@users.noreply.github.com>

Delete got package by yarn remove command

0174d36

HiroyukiNaito and others added 8 commits February 29, 2024 16:59

Delete

39c4bd1

Delete downloadOrCopyFile(pathDest: string, urlOrPathSrc: string): Pr…

5bbc97c

…omise<void>

Update packages/cli/test/utils/simulation/beacon_clients/lighthouse.ts

d573a50

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

Update packages/cli/test/utils/simulation/beacon_clients/lodestar.ts

cbdd24b

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

Changed Fetch error

193ad5a

Changed to return Buffer.from(await res.arrayBuffer());

e9d8b77

Edited downloadTestFile

fe41173

Changed some codes

273f5c5

HiroyukiNaito changed the title ~~fix: remove got dependency #6866~~ chore: remove got dependency Feb 29, 2024

HiroyukiNaito added 3 commits February 29, 2024 20:10

Merge remote-tracking branch 'upstream/unstable' into unstable

ad0bdf1

Added Error check logic

087589f

Changed for PR

ae3f92c

nflaig reviewed Feb 29, 2024

View reviewed changes

packages/cli/src/util/file.ts Outdated Show resolved Hide resolved

packages/cli/test/utils/simulation/beacon_clients/lodestar.ts Outdated Show resolved Hide resolved

packages/cli/src/networks/index.ts Outdated Show resolved Hide resolved

HiroyukiNaito added 2 commits February 29, 2024 21:10

Delete a unused function downloadFilefunction downloadFile in files.ts

56f644b

Alighed Error message

2b2e1e1

nflaig reviewed Feb 29, 2024

View reviewed changes

packages/cli/src/networks/index.ts Outdated Show resolved Hide resolved

packages/cli/test/utils/simulation/beacon_clients/lighthouse.ts Outdated Show resolved Hide resolved

nflaig reviewed Feb 29, 2024

View reviewed changes

Added fetch "@lodestar/api";

fcaf7ea

HiroyukiNaito force-pushed the unstable branch from 83c6e94 to fcaf7ea Compare March 1, 2024 11:55

HiroyukiNaito added 3 commits March 1, 2024 21:06

Deleted (err instanceof FetchError && err.code !== "ECONNREFUSED") logic

e92c5ba

added HealthStatus

ba0b674

Added Utility function for postEthRpc

a44139e

HiroyukiNaito requested a review from jeluard March 1, 2024 17:46

HiroyukiNaito commented Mar 1, 2024

View reviewed changes

HiroyukiNaito added 4 commits March 2, 2024 23:10

Changed Error handling

19c016c

Lint fix

0ce433a

Mistakely deleted lint restored.

f775aff

Lint corrected

e90a890

HiroyukiNaito requested a review from nflaig March 2, 2024 14:42

HiroyukiNaito commented Mar 2, 2024

View reviewed changes

HiroyukiNaito commented Mar 3, 2024

View reviewed changes

HiroyukiNaito marked this pull request as draft March 11, 2024 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove got dependency #6497

chore: remove got dependency #6497

HiroyukiNaito commented Feb 28, 2024 •

edited

CLAassistant commented Feb 28, 2024 •

edited

jeluard left a comment

nflaig commented Feb 28, 2024

jeluard commented Feb 28, 2024

HiroyukiNaito commented Feb 29, 2024

nflaig left a comment

HiroyukiNaito commented Mar 1, 2024 •

edited

HiroyukiNaito Mar 1, 2024 •

edited

codecov bot commented Mar 2, 2024

HiroyukiNaito Mar 2, 2024 •

edited

HiroyukiNaito Mar 3, 2024

chore: remove got dependency #6497

Are you sure you want to change the base?

chore: remove got dependency #6497

Conversation

HiroyukiNaito commented Feb 28, 2024 • edited

CLAassistant commented Feb 28, 2024 • edited

jeluard left a comment

Choose a reason for hiding this comment

nflaig commented Feb 28, 2024

jeluard commented Feb 28, 2024

HiroyukiNaito commented Feb 29, 2024

nflaig left a comment

Choose a reason for hiding this comment

HiroyukiNaito commented Mar 1, 2024 • edited

Remaining task

4XX-5XX Error

Other error

HiroyukiNaito Mar 1, 2024 • edited

Choose a reason for hiding this comment

codecov bot commented Mar 2, 2024

Codecov Report

HiroyukiNaito Mar 2, 2024 • edited

Choose a reason for hiding this comment

HiroyukiNaito Mar 3, 2024

Choose a reason for hiding this comment

HiroyukiNaito commented Feb 28, 2024 •

edited

CLAassistant commented Feb 28, 2024 •

edited

HiroyukiNaito commented Mar 1, 2024 •

edited

HiroyukiNaito Mar 1, 2024 •

edited

HiroyukiNaito Mar 2, 2024 •

edited