Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mockExecutionEngine without checking parentHash #6323

Draft
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

yrong
Copy link

@yrong yrong commented Jan 18, 2024

Motivation

Start the beacon node in mock mode without requiring an execution node.

Description

#6188

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2024

CLA assistant check
All committers have signed the CLA.

@yrong yrong changed the title MockExecutionEngine without check parentHash fix: mockExecutionEngine without check parentHash Jan 18, 2024
@yrong yrong changed the title fix: mockExecutionEngine without check parentHash fix: mockExecutionEngine without checking parentHash Jan 18, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Merging #6323 (2034ecd) into unstable (551fd8e) will not change coverage.
Report is 6 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6323   +/-   ##
=========================================
  Coverage     76.53%   76.53%           
=========================================
  Files           248      248           
  Lines         25943    25943           
  Branches       1449     1449           
=========================================
  Hits          19855    19855           
  Misses         6058     6058           
  Partials         30       30           

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just remove those checks like this a we use the engine mock for testing as well.

I think the engine mock is useful for people that want to quickly spin up a node on any network and we should think about how we can make it so it does not report syncing unless the node is synced from genesis.

Since the engine mock is not secure either way as it does not validate the execution payloads I think removing the parent hash validation doesn't matter much but I would like to hear what others have to say about this.

I am in favor of removing this and for testing, we can explicitly configure the engine mock to do parent hash validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants