feat: add historical state regen #6033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
twoeths
reviewed
Oct 12, 2023
packages/beacon-node/src/chain/historicalState/getHistoricalState.ts
Outdated
Show resolved
Hide resolved
nflaig
reviewed
Oct 13, 2023
dapplion
reviewed
Oct 16, 2023
|
Running into issues opening the db in the worker thread. It seems the leveldb way of allowing concurrency is have the consumer pass the pointer to the db handle to another thread. That's not currently possible with the leveldb package as it currently exists. |
|
Converting to draft until the multithreaded database access issue is resolved |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6033 +/- ##
=============================================
- Coverage 76.60% 60.14% -16.46%
=============================================
Files 248 407 +159
Lines 25908 46464 +20556
Branches 1448 1534 +86
=============================================
+ Hits 19846 27947 +8101
- Misses 6032 18487 +12455
Partials 30 30 |
matthewkeil
requested changes
Feb 8, 2024
| } | ||
|
|
||
| async function resolveStateIdOrNull( |
There was a problem hiding this comment.
I like this being renamed. good call!
| return state; | ||
| } | ||
|
|
||
| export async function getStateResponseWithRegen( |
There was a problem hiding this comment.
Should this be combined with getStateResponse. can pass a third arg allowRegen that passes to the getStateByStateRoot, getStateBySlot and gates getHistoricalStateBySlot
| if (stateId === "head") { | ||
| // TODO: This is not OK, head and headState must be fetched atomically |
There was a problem hiding this comment.
Two questions:
-
is the issue about mutability in case there is a slot boundary while this resolves? Or is the issue that
getHeadStatecan mutate state during its run? -
If there is risk, should we leave this comment here, maybe move to
getStateResponseor perhaps convert it to aTODOto make sure this doesn't get papered over?
There was a problem hiding this comment.
I think the issue before was that the calls were unlinked and also async.
eg:
const head = chain.forkChoice.getHead();
// what happens if the head changes before this next line
const headState = await chain.getHeadState();Then they were unlinked but sync (no problem, stale comment).
const head = chain.forkChoice.getHead();
// no chance for the head to change before this next line
const headState = chain.getHeadState();Now they are linked / looked up by state root
const head = chain.forkChoice.getHead();
// ...
// the head may change, but the head _at the time of request_ can still be fetched
const headState = chain.getStateByRoot(head.stateRoot);| } | ||
|
|
||
| return stateRes; | ||
| export function deserializeBeaconStateSerialized(config: ChainForkConfig, data: Uint8Array): allForks.BeaconState { |
There was a problem hiding this comment.
Suggested change
| export function deserializeBeaconStateSerialized(config: ChainForkConfig, data: Uint8Array): allForks.BeaconState { | |
| export function deserializeBeaconState(config: ChainForkConfig, data: Uint8Array): allForks.BeaconState { |
|
|
||
| const db = new BeaconDb(config, await LevelDbController.create({name: workerData.dbLocation}, {logger})); | ||
|
|
||
| const abortController = new AbortController(); |
There was a problem hiding this comment.
Why do we actually need this AbortController here if it will not be synchronized with the main thread. The kill signal comes from the outside
| config, | ||
| metrics, | ||
| logger: logger.child({module: LoggerModule.chain}), | ||
| }); |
There was a problem hiding this comment.
Should the abort controller above get passed into HistoricalStateRegen.init so this shutdown is coordinated with the rest of the application? Im a bit fuzzy on how cleanup happens so this may not be correct though....
Comment on lines
+41
to
+46
| const closeMetrics = collectNodeJSMetrics(metricsRegister, "lodestar_historical_state_worker_"); | ||
| abortController.signal.addEventListener("abort", closeMetrics, {once: true}); | ||
|
|
||
| stateTransitionMetrics = { | ||
| epochTransitionTime: metricsRegister.histogram({ | ||
| name: "lodestar_historical_state_stfn_epoch_transition_seconds", |
There was a problem hiding this comment.
Doesn't lodestar_historical_state_worker_ get prepended to all of these metric names? If so we will have some super long names and the lodestar_historical_state_ will be redundant on all of them
Comment on lines
+62
to
+64
| export function getBlocksBetween(from: number, to: number, db: IBeaconDb): AsyncIterable<SignedBeaconBlock> { | ||
| return db.blockArchive.valuesStream({gt: from, lte: to}); | ||
| } |
There was a problem hiding this comment.
Is there a specific reason you broke this out? Can we just directly call db.blockArchive.valuesStream in the for await below and save a stack frame?
There was a problem hiding this comment.
no reason, just started the implementation of getHistoricalState in pseudocode and this stuck around. I can remove
| workerData, | ||
| } as ConstructorParameters<typeof Worker>[1]); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
I didn't notice that this needs to be here. Deleted with no issue
|
Any update on the status of this PR? Are we blocked on it somewhere externally? |
waiting on me to fix this in response to @matthewkeil 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
TODO