-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: de-duplicate payloads from persisted beacon blocks #6029
Draft
matthewkeil
wants to merge
49
commits into
unstable
Choose a base branch
from
mkeil/dedup-beacon-block-2
base: unstable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
7fe92f5
WIP with FullOrBlindedSignedBeaconBlock
dapplion 1d46517
fix(repositories): block type only change to FullOrBlinded
matthewkeil c99030e
Draft consumer points
dapplion e119753
fix: update IBeaconChain and clear error in beaconBlocksByRoot
matthewkeil 9d438a4
wip: TODOs. remove commit
matthewkeil 5f32489
fix: rough out to get building
matthewkeil 758005e
feat: move utils to fullOrBlindedBlock.ts
matthewkeil afd645c
feat: build out fullOrBlindedBlock.ts
matthewkeil 375f002
feat: implement consumers of fullOrBlindedBlock.ts
matthewkeil 6793707
test: fullOrBlindedBlock and add mocks
matthewkeil 821ea79
feat: block reassembly as generator
matthewkeil bee326c
feat: make getBlockHeaders blinded safe
matthewkeil 617dc22
test: debugging fullOrBlindedBlock
matthewkeil f9ed0b0
fix: bellatrix reassembleBlindedOrFullToFullBytes
matthewkeil 0d27985
fix: capella reassembleBlindedOrFullToFullBytes
matthewkeil 4f1ad7b
test: debug fullOrBlindedBlock.ts
matthewkeil 358c49a
test: fix mocks and get mocks/block modifying for minimal and mainnet
matthewkeil d5dd74d
refactor: rename blindedBlockToFullBytes in chain/interface
matthewkeil 488294f
test: fix mocks and get mocks/block modifying for minimal and mainnet
matthewkeil c7c486b
feat: pull payload from execution layer
matthewkeil f7eda87
chore: fix lint issues
matthewkeil b834932
chore: fix check-types error
matthewkeil 08f7e9a
fix: use toHexString for executionEngine call
matthewkeil 9754368
fix: optional chain to fix .timestamp access error
matthewkeil ac5e40a
refactor: ensure "blindedOrFullBlock" to function names
matthewkeil a208b24
test: add byteArrayEqualsThrowBadIndexes
matthewkeil d96a4e4
refactor: standardize function names
matthewkeil 4e69106
test: perf of not converting serialized
matthewkeil af94fcb
refactor: update comment to be more clear
matthewkeil 6aaa250
refactor(beacon-node): make fullOrBlinded function names all consistent
matthewkeil ee6953b
fix: add any in beacon-node/test/unit/fullOrBlindedBlock.test for che…
matthewkeil 89a1e48
refactor: remove commented mocks that were updated
matthewkeil 909b7b6
chore: fix lint error
matthewkeil d17136b
refactor: simplify TransactionAndWithdrawals type
matthewkeil 03fa617
fix: remove comments making sure there are tests for fullOrBlinded in…
matthewkeil 0aa9e14
refactor: export chainConfig for use in tests that consume the mockBl…
matthewkeil 37147ad
test: update workflow with new containers
matthewkeil 844e6cb
test: revert workflow to original container versions
matthewkeil 077bcca
feat: throw Eth1Error for invalid payload body
matthewkeil 9e89430
fix: convert all json to ssz fixtures
matthewkeil bc8e6b7
fix: remove serialized blind/unblind code paths
matthewkeil 22d7ae6
chore: fix lint error
matthewkeil 0d08933
refactor: clean up fullOrBlindedBlock
matthewkeil a07b3ab
fix: debugged test:sim:multifork
matthewkeil 62619a9
fix: debug broken test:sim:deneb
matthewkeil 9489edd
fix(workflows): comment out broken sim tests for now
matthewkeil 554c33d
fix: name conflict from rebase to unstable
matthewkeil 9a60b32
test: update fullOrBlinded.test to vitest imports
matthewkeil adfa2f5
fix: edge case for GENESIS_SLOT as post-altair block
matthewkeil File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its cleaner to extend blockToHeader to accept full or blinded,
also then the root above can be calulated from the header returned by hashtree root of the blockheader ... it should be more efficient since body won't be merklized twice