-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create /final/ permalinks for final CAIPs #269
Open
bumblefudge
wants to merge
9
commits into
main
Choose a base branch
from
feat/add-finals
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For context see https://github.com/ethcatherders/EIPIP issue 320 |
bumblefudge
changed the title
WIP - create extra /final/ permalinks for final CAIPs
Create /final/ permalinks for final CAIPs
Apr 16, 2024
@ligi - whenever you have some time can you take a look here / quick review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to make an extra /final/ path freezing a second copy (at a second path) of each CAIP at the time it goes final.
While I was in here, I updated what little is said about the "status" field and its values in CAIP-1, and updated contributing.md to be more explicit about all this for contributors. @ligi might want to check the CAIP-1 edits!
As for next steps, I keep wondering what this means for errata or post-final edits. I think the best solution would probably be to display links back and forth between the
/final/
version and the "post-final" version that lives on in/CAIPs/
which would be the equivalent of a W3C "Editor's Draft" (a less-binding version with errata applied or displayed as a differential in-line, IETF style). If the editorial WG agrees, we can open a separate issue for that tweak.Similarly, I wonder if having an ipfs://{cid} version of each final might also be good, just in case. Also worth its own issue if that's an idea worth playing with.