Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a caip24 proposal for cosmos caip19 asset namespace to make cos… #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theoboldfrazier
Copy link

@theoboldfrazier theoboldfrazier commented May 6, 2022

This PR would extend the CAIP19 standard for cosmos native and ibc assets. Currently, the CAIP19 is insufficient for dealing with non-native, or "non-base", cosmos assets.

Example: Osmo on the Osmosischain would have a caip 19 cosmos:osmosis-1/slip44:118 but for the native ion asset on the osmosis chain, there is no good caip19 in the current standard.

This PR would label the ion asset on the osmosis chain cosmos:osmosis-1/native:uion.

Furthermore, it would expand caip19 to handle ibc assets on cosmos network chains. For example, ATOM on the osmosis chain would have a caip19 of cosmos:osmosis-1/ibc:27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2

#2)

* added a caip24 proposal for cosmos caip19 asset namespace to make cosmos asset references unique

* Update CAIPs/caip-24.md

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* Update CAIPs/caip-24.md

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* Update CAIPs/caip-24.md

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* Update CAIPs/caip-24.md

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>

* added IBC asset reference def.

* Update CAIPs/caip-24.md

Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>

* fixed header grammer

* capitalized Cosmos

* Update CAIPs/caip-24.md

Co-authored-by: Alexandre GOMES <17035424+gomesalexandre@users.noreply.github.com>

* cleaned up grammer/spelling

* Update CAIPs/caip-24.md

Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>

* Update CAIPs/caip-24.md

Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>

Co-authored-by: 0xdef1cafe <88504456+0xdef1cafe@users.noreply.github.com>
Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
Co-authored-by: Alexandre GOMES <17035424+gomesalexandre@users.noreply.github.com>
@cjthompson
Copy link

cjthompson commented May 6, 2022

This proposal is sponsored and supported by the ShapeShift DAO. We are currently using this implementation in our library packages.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We just move all namespace related stuff here: https://github.com/ChainAgnostic/namespaces
Would be great if you could submit it there. Sorry for getting caught in the middle of it - but the move should be easy. That said we should finish the move soon so this does not happen anymore.

cc @bumblefudge

@ligi
Copy link
Member

ligi commented May 8, 2022

This proposal is sponsored and supported by the ShapeShift DAO. We are currently using this implementation in our library packages.

nice! Think ShapeShift DAO should be added here then: https://github.com/ChainAgnostic/CASA#members can you add a PR for that?

@bumblefudge
Copy link
Collaborator

super cool, guys! could I ask you to check out namespaces/template and caip104 and rework your PR to fit the model of:
namespaces/cosmos/caip19.md
? Ping me if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants