Fix local DEM with UTM projection

[ThomasPe]

Rearranges some code that's required for both Earth Engine & local DEMs

[ChHarding]

Thomas, I looked your "Fix bug for local DEM in UTM" and I don’t understand the reason. You moved a block (710 - 731) from its original place inside method A (d/l geotiff from EarthEngine), however, all the region calculations it does only make sense in to context of getting of method A. I assume you are using the local geotiff file (method B), which does similar calculations based on the metadata encoded in the geotiff. So I don’t see what was fixed with moving the block? Maybe this helps: although you could put an extend in your JSON config file (trlat, talon, etc.) these are ignored when you use the importedDEM setting for a local geotiff. So it’s technically possible that our block does calculations based on those ignored extent values but those should be overwritten inside method B based on the geotiff. Or am I missing something (entirely possible!) ? Cheers Chris On Dec 25, 2023, at 10:00, Thomas Pentenrieder ***@***.******@***.***>> wrote: Rearranges some code that's required for both Earth Engine & local DEMs

…

________________________________ You can view, comment on, or merge this pull request online at: #85 Commit Summary * 42fdfde<42fdfde> Fix bug for local DEM in UTM * 4cd9d8d<4cd9d8d> Merge branch 'ChHarding:master' into master File Changes (1 file<https://github.com/ChHarding/TouchTerrain_for_CAGEO/pull/85/files>) * M touchterrain/common/TouchTerrainEarthEngine.py<https://github.com/ChHarding/TouchTerrain_for_CAGEO/pull/85/files#diff-e4923bfbe7331ec6ca22eb7564054e0cfac7bf34073bee053a50fb23749c0e17> (51) Patch Links: * https://github.com/ChHarding/TouchTerrain_for_CAGEO/pull/85.patch * https://github.com/ChHarding/TouchTerrain_for_CAGEO/pull/85.diff — Reply to this email directly, view it on GitHub<#85>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEYDF5LXDKKNQDEUOQLKJR3YLGPIZAVCNFSM6AAAAABBCORWSWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKNZWGA3DCNY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> Chris Harding Associate Professor Department of Geological & Atmospheric Sciences Touchterrain.geol.iastate.edu<http://Touchterrain.geol.iastate.edu>

[ThomasPe]

TBH I didn't completely think through the whole code, but not providing a tilewidth_scale value gave me errors. But when providing a value the region_ratio gets recalculated in line 1190 (my code) which requires region_size_in_meters to be assigned. That's why I pulled that part out of method A.

For my case providing a tilewidth_scale of 1000 should get me back to meters which I need for aligning with the other STL.