Add splitDirection property for PointPrimitive #11982
Open
+126
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the splitDirection property to PointPrimitive. Updated PointPrimitive Collection and shaders to work with the property.
Added the splitDirection property to PointPrimitive. Updated PointGraphics and PointVisualizer.
Updated Specs PointPrimitive Collection, Point Graphics and PointVisualizer to work with the new splitDirection property
|
Thank you for the pull request, @YunVlad! ✅ We can confirm we have a CLA on file for you. |
|
Awesome, thanks for the contribution @YunVlad! We'll review this shortly! |
Fixed formatting in PointGraphics, PointVisualizer, PointPrimitive, PointGraphicsSpec
Resolving conflict
ggetz
reviewed
May 29, 2024
CHANGES.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Change Log | |||
|
|
|||
| - Added SplitDirection property for display PointPrimitive relative to the `Scene.splitPosition`. | |||
There was a problem hiding this comment.
Could you please
- merge in the
mainbranch and resolve any conflicts - Add a link to this PR, ie
[11982](https://github.com/CesiumGS/cesium/pull/11982)
| @@ -497,6 +500,12 @@ function createVAF(context, numberOfPointPrimitives, buffersUsage) { | |||
| componentDatatype: ComponentDatatype.FLOAT, | |||
| usage: buffersUsage[DISTANCE_DISPLAY_CONDITION_INDEX], | |||
| }, | |||
| { | |||
| index: attributeLocations.splitDirection, | |||
There was a problem hiding this comment.
To save on the number of attributes, which is limited, let's pack this single float component along with distanceDisplayConditionAndDisableDepth as a 4th component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the splitDirection property for PointPrimitive.
Objects for which splitDirection is set as SplitDirection.NONE (by default) will be displayed to the right and left of Scene.splitPosition.
Objects for which splitDirection is set as SplitDirection.LEFT will be displayed to the left of Scene.splitPosition.
Objects for which splitDirection is set as SplitDirection.RIGHT will be displayed to the right of Scene.splitPosition.
This property is necessary for marking points of interest and subsequent analysis of changes over time.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change