Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5076] fix: oai-pmh feed #816

Merged
merged 2 commits into from May 20, 2024
Merged

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Feb 9, 2024

  • derive oai_dc xml from indexcard rdf
  • add notify_index param to task__derive to allow deriving without hitting search indexes (default True to match current behavior)
  • update task__schedule_all_for_deriver to pass notify_index=False to task__derive by default
  • add tests.trove.derive

ENG-5076

@aaxelb aaxelb changed the title fix: oai-pmh feed [ENG-5076] fix: oai-pmh feed Feb 9, 2024
@coveralls
Copy link

coveralls commented Feb 9, 2024

Coverage Status

coverage: 89.742% (+0.3%) from 89.424%
when pulling e3bcbf2 on aaxelb:fix/oai-pmh
into 9fd7738 on CenterForOpenScience:develop.

@aaxelb aaxelb force-pushed the fix/oai-pmh branch 5 times, most recently from 83f14b6 to 9aa7b17 Compare May 16, 2024 20:39
- derive `oai_dc` xml from indexcard rdf
- add `notify_index` param to `task__derive` to allow deriving *without*
  hitting search indexes (default `True` to match current behavior)
- update `task__schedule_all_for_deriver` to pass `notify_index=False`
  to `task__derive` by default
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@aaxelb aaxelb merged commit b0ca69a into CenterForOpenScience:develop May 20, 2024
3 checks passed
@aaxelb aaxelb deleted the fix/oai-pmh branch May 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants