Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE:#41 ADDED CAROUSEL SLIDER TO SHOW OUR APPS SCREENSHOTS #66

Open
wants to merge 2 commits into
base: website
Choose a base branch
from

Conversation

krushn-a
Copy link

@krushn-a krushn-a commented May 31, 2023

Related Issue(s)

ISSUE:#41 Carousel Slider was not present in the "Show our Apps ScreenShots"

Proposed Changes

Carousel Slider is applied to all devices

Type of Change

  • New Feature (Landing Page)

Your Idea for Level (GSSoC)

  • Level 1
  • Level 2
  • Level 3

Screenshots (if applicable)

2023-06-01

Additional Notes

Copy link
Member

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand what happened here. What was happening and also why so much duplication? Why did you edit the library files?

@krushn-a
Copy link
Author

krushn-a commented Jun 5, 2023

So what i did is as it was using owl carousel so first i change the nav attribute to true in script.js to turn on the carousel feature. and then i have added css related to carousel in owl.carousel.min.css, owl.theme.default.min.css and responsive.css. And can you please elaborate about library files issue so that i can figure what wrong i have done.

@krushn-a
Copy link
Author

krushn-a commented Jun 5, 2023

Every time i tried the whole file get duplicated, i am also not getting how is it happening, eventhough i have never deleted anything, though i have just added one line of code.

@praveenscience
Copy link
Member

Oh wow, interesting, let me check.

@praveenscience
Copy link
Member

@krushn-a One last thing, on the responsive.css can you just make them aligned and indented?

@krushn-a
Copy link
Author

krushn-a commented Jun 6, 2023

Yeah, sure..

@krushn-a
Copy link
Author

krushn-a commented Jun 6, 2023

2023-06-06 (1)
2023-06-06

In my local system its already indented and aligned but when i tried to push to github, in github its somehow gets unindented.

@krushn-a
Copy link
Author

krushn-a commented Jun 6, 2023

Is there any way to solve this problem.

@praveenscience
Copy link
Member

I am not sure, it is very interesting here, anyway, don't worry, let me fix it and merge it tomorrow. Is that alright? 🤔

@krushn-a
Copy link
Author

krushn-a commented Jun 7, 2023

Yeah, sure

@krushn-a
Copy link
Author

hello @praveenscience can I get any updates regarding my PR?

@krushn-a
Copy link
Author

Hi @praveenscience can I get any updated regarding my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants