Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Dockerized the Website using Docker and Nginx" #16

Open
wants to merge 2 commits into
base: website
Choose a base branch
from
Open

"Dockerized the Website using Docker and Nginx" #16

wants to merge 2 commits into from

Conversation

RohanRusta21
Copy link

Please Review & Approve.
@praveenscience @vinitshahdeo @Nikhar444 @vermakhushboo

Thanks,
Rohan

praveenscience
praveenscience requested changes May 28, 2023
View reviewed changes
Copy link
Member

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Cloudflare Pages or Netlify or Surge will work with Docker. 🤔

@RohanRusta21
Copy link
Author

I don't think Cloudflare Pages or Netlify or Surge will work with Docker. 🤔

I think for that we can use github workflows for smooth and automatic deployment.

@praveenscience
Copy link
Member

Deploying to where? 🤔

@praveenscience
Copy link
Member

These are amazing, but why? What's the use-case? We just have a simple HTML & CSS landing page. I don't understand where's this going to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenscience praveenscience praveenscience requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RohanRusta21 @praveenscience