Use updated dependencies when building with Swift 5, but keep backwards-compatibility with Swift 4 #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottwilliams
commented
Jun 14, 2020
| #if compiler(>=5) | ||
| compilerSpecificDependencies = [ | ||
| .package(url: "https://github.com/antitypical/Result.git", from: "5.0.0"), | ||
| .package(url: "https://github.com/Carthage/ReactiveTask.git", .branch("release-0.17.0")), |
There was a problem hiding this comment.
release-0.17.0 is the branch of Carthage/ReactiveTask#120, which has been open for a year :)
AFAICT, nothing is preventing that PR from being merged, there just hasn't been a reason to yet. It needs to get merged before this PR, since versioned packages can't have branch dependencies.
…building on Swift 5
elliottwilliams
force-pushed
the
swift_5_conditional_compilation
branch
from
275cdcd
to
0e0b1ee
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complement to #2972, but doesn't make any breaking changes to CI / homebrew. It starts the work of upgrading to Swift 5.2 by using updated dependencies when Carthage is built with a 5.x compiler. These changes are helpful for users who depend on Carthage as a SwiftPM package [1], and should make it a little easier to drop support for Swift 4.x in the future.
[1]: Carthage doesn't build with Commandant >= 0.17.0, because that version drops support for antitypical/Result. You can manually pin Commandant to an older version, but then you can't depend on tools that have upgraded to the newer version of Commandant, like SwiftLint. So this PR helps keep users out of dependency hell when they're using SwiftPM to version their build tools.