Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previously removed GitHub Actions for running tests #2968

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

DavidBrunow
Copy link
Contributor

@DavidBrunow DavidBrunow commented Apr 11, 2020

These were removed in this commit: ba6bc29

The tests on GitHub Actions have been running faster than the tests on Travis. Unfortunately the GitHub Actions do not support Xcode 10.1 so we still need the tests running on Travis.

@DavidBrunow DavidBrunow changed the title Create GitHub Actions for running integration tests Add previously removed GitHub Actions for running integration tests Apr 11, 2020
@DavidBrunow DavidBrunow changed the title Add previously removed GitHub Actions for running integration tests Add previously removed GitHub Actions for running tests Apr 11, 2020
@tmspzz tmspzz self-requested a review April 11, 2020 15:50
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: actions/checkout@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v1
- uses: actions/checkout@v2

env:
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app
steps:
- uses: actions/checkout@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v1
- uses: actions/checkout@v2


jobs:
test:
runs-on: macOS-10.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stale
Copy link

stale bot commented May 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 23, 2020
@ikesyo ikesyo removed the stale label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants