Add support for additional framework extensions #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relikd
changed the title
|
I'm surprised how little work this took. Well done 👍 |
tmspzz
approved these changes
Aug 5, 2019
mdiep
approved these changes
Aug 6, 2019
relikd
commented
Aug 6, 2019
|
Yup, that's what I was thinking |
robb
reviewed
Aug 8, 2019
relikd
commented
Aug 8, 2019
Co-Authored-By: Robert Böhnke <212465+robb@users.noreply.github.com>
|
|
|
@relikd yeah, don't worry about that one. |
|
@jdhealy you self-requested a review a while ago, did you find time? |
This comment has been minimized.
This comment has been minimized.
|
Sad to see that after two months nothing really changed. Can you re-run Travis so that the checks succeed? |
|
Is it ok to bump the topic every once in a while? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following bundle extensions:
.framework,.action,.bundle,.kext,.mdimporter,.metallib,.plugin,.prefPane,.qlgenerator,.saver,.xpcIncluding (un-)archiving as well as support for binary releases.
This list can be extended in
ProductExtension.swift.Should streamline plugin creation (e.g., QuickLook plugins) and integration in other projects.