-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported pairs query #170
Conversation
It's not a part of this PR but maybe it could be fixed here as it touches bridge_weth.ts file: most/azero/scripts/bridge_weth.ts Lines 14 to 20 in 9a35d3a
function getTokenAddresses(addresses, tokenName): [string, string] {
for (let [_tokenName, ethAddress, azeroAddress] of addresses.tokens) {
if (tokenName == _tokenName) {
return [ethAddress, azeroAddress];
}
}
} most/azero/scripts/bridge_weth.ts Line 28 in 9a35d3a
const weth_azero = getTokenAddresses(addresses, "wETH")[1]; |
Pushed in 1302d73 |
Can we merge this @krzysztofziobro @obrok ? Best before mainnet release I suppose? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would merge it, but I think it would be nice to add here also getters for fee constants + I would remove the upgrade script (upgrades need to be manual performed by the contract owner anyway).
Done, please double check me if we're not missing sth |
Adding a missing query on the azero contract ( supported pairs )