Relayer suggestions #115
Closed
Relayer suggestions #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrok
reviewed
Mar 1, 2024
Comment on lines
+165
to
+172
| // [Audit] Have we considered checking somehow type of the signed transaction, | ||
| // or even changing the interface to accept only transactions that are calls | ||
| // to Most or Advisory contracts? Don't know how enclaves exactly work, but I | ||
| // assume that if an attacker can broke into the EC2 instance, then they | ||
| // could create extra connection to the enclave on which the signer is running, | ||
| // and sing anything they want, including draining all AZero and ETH from the guardian. | ||
| // This already isn't that bad, compared to having the key compromised, as at least we'd | ||
| // have some tracks of the incident probably, but maybe we could add that extra layer of security? |
There was a problem hiding this comment.
I specifically didn't want to do that to keep the signer as simple as possible to limit other possible bugs. So my choice was to have it be an abstract signer of bytes. From what I understand it would also be quite unwieldy to deploy - any change to the signer (not the relayer) requires rebuilding the enclave, giving it access to the signing keys, etc. - relatively high-security operations. So if anything simple happened where we needed to sign a new kind of transaction (like in fact we're planning to do when we finally add the ability for the relayer to pay out fees) we would have to go through that painful process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.