Review eth contract #114
Closed
Review eth contract #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbielejec
reviewed
Mar 6, 2024
fbielejec
reviewed
Mar 6, 2024
fbielejec
reviewed
Mar 6, 2024
| @@ -100,6 +100,12 @@ contract Most is | |||
| // | |||
| // Tx emits a CrosschainTransferRequest event that the relayers listen to | |||
| // & forward to the destination chain. | |||
|
|
|||
| // let's use modern standards. | |||
There was a problem hiding this comment.
can you clarify this comment a bit, I'm not sure I follow.
Regardless of whether the allowance is increased via approve or permit the end result is the same - Most can spend up to a value on behalf of the sender, so it's more of a concern for the fronted to distinguish if token implement the ERC and whether to ask the user to sign a permit or just a plain approval tx ?
There was a problem hiding this comment.
permit allows someone to execute approve on behalf of someone else. For the bridge frontend client, it might not be that useful. But for some users of bridge, who want to cross-contract call the bridge it might be very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.