add ManaCostShard Map and cleanup Desktop and Mobile #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanmac
changed the title
|
Looks good so far! :) |
tool4ever
reviewed
May 17, 2024
tool4ever
previously requested changes
May 17, 2024
There was a problem hiding this comment.
I tried to select Ayara, Widow of the Realm in deck editor:
EDT > java.lang.NullPointerException: Cannot invoke "forge.toolbox.FSkin$SkinImage.resize(int, int)" because the return value of "java.util.Map.get(Object)" is null
at forge.toolbox.CardFaceSymbols.drawSymbol(CardFaceSymbols.java:274)
at forge.toolbox.imaging.FCardImageRenderer$SymbolPiece.drawCurrent(FCardImageRenderer.java:977)
at forge.toolbox.imaging.FCardImageRenderer$Paragraph.drawPieces(FCardImageRenderer.java:1086)
at forge.toolbox.imaging.FCardImageRenderer.drawTextBoxText(FCardImageRenderer.java:1156)
at forge.toolbox.imaging.FCardImageRenderer.drawTextBox(FCardImageRenderer.java:822)
at forge.toolbox.imaging.FCardImageRenderer.drawCardStateImage(FCardImageRenderer.java:425)
at forge.toolbox.imaging.FCardImageRenderer.drawCardImage(FCardImageRenderer.java:279)
at forge.ImageCache.getOriginalImageInternal(ImageCache.java:310)
at forge.ImageCache.getOriginalImage(ImageCache.java:158)
at forge.toolbox.imaging.FImageUtil.getImage(FImageUtil.java:59)
at forge.gui.CardPicturePanel.getImage(CardPicturePanel.java:136)
at forge.gui.CardPicturePanel.setImage(CardPicturePanel.java:92)
at forge.gui.CardPicturePanel.setCard(CardPicturePanel.java:85)
at forge.screens.match.controllers.CPicture.showCard(CPicture.java:75)
at forge.screens.match.controllers.CDetailPicture.update(CDetailPicture.java:97)
at forge.screens.match.controllers.CDetailPicture.showCard(CDetailPicture.java:52)
at forge.screens.match.controllers.CDetailPicture.showItem(CDetailPicture.java:72)
at forge.screens.deckeditor.CDeckEditorUI.setCard(CDeckEditorUI.java:100)
at forge.screens.deckeditor.CDeckEditorUI$7.valueChanged(CDeckEditorUI.java:279)
at forge.itemmanager.views.ItemView.onSelectionChange(ItemView.java:311)
at forge.itemmanager.views.ItemListView$ItemTableModel$2.focusGained(ItemListView.java:611)
d5fa282
to
e0ce52e
Compare
tool4ever
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5207
First Step in cleaning up the code
This Part is for Desktop
For Mobile, the problem is the extra Enum FSkinImage in between, i need to think about that can be removed/refactored too