Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft Matters - How many cards you've drafted this round #5203

Merged
merged 10 commits into from
May 21, 2024

Conversation

tehdiplomat
Copy link
Contributor

No description provided.

@tehdiplomat tehdiplomat marked this pull request as ready for review May 17, 2024 21:43
@tehdiplomat tehdiplomat changed the title Initial checkin for How many cards you've drafted this round Draft Matters - How many cards you've drafted this round May 19, 2024
Copy link
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a Conspiracy Draft and ended up with a Deck that had:

DraftNotes=Lurking Automaton:1, 2, 6, 7

Tried to play a game to cast this card and got this:

Game-0 > java.lang.NumberFormatException: For input string: " 2"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:68)
	at java.base/java.lang.Integer.parseInt(Integer.java:638)
	at java.base/java.lang.Integer.parseInt(Integer.java:770)
	at forge.game.ability.AbilityUtils.xCount(AbilityUtils.java:2366)
	at forge.game.ability.AbilityUtils.calculateAmount(AbilityUtils.java:483)
	at forge.game.ability.AbilityUtils.calculateAmount(AbilityUtils.java:402)
	at forge.game.ability.effects.CountersPutEffect.resolve(CountersPutEffect.java:589)
	at forge.game.spellability.AbilitySub.resolve(AbilitySub.java:105)
	at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1386)
	at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1354)
	at forge.player.HumanPlaySpellAbility.playAbility(HumanPlaySpellAbility.java:212)
	at forge.player.HumanPlay.playSpellAbilityNoStack(HumanPlay.java:184)
	at forge.player.PlayerControllerHuman.playSpellAbilityNoStack(PlayerControllerHuman.java:315)
	at forge.game.replacement.ReplacementHandler.executeReplacement(ReplacementHandler.java:367)
	at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:226)
	at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:197)
	at forge.game.GameAction.changeZone(GameAction.java:341)
	at forge.game.GameAction.moveTo(GameAction.java:777)
	at forge.game.GameAction.moveTo(GameAction.java:737)
	at forge.game.GameAction.moveToPlay(GameAction.java:870)
	at forge.game.ability.effects.PermanentEffect.resolve(PermanentEffect.java:36)
	at forge.game.ability.SpellApiBased.resolve(SpellApiBased.java:51)
	at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1386)
	at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1354)
	at forge.game.zone.MagicStack.resolveStack(MagicStack.java:591)
	at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:1126)
	at forge.game.GameAction.startGame(GameAction.java:2107)
	at forge.game.Match.startGame(Match.java:90)
	at forge.gamemodes.match.HostedMatch$2.run(HostedMatch.java:274)

Copy link
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tool4ever tool4ever merged commit 6087167 into master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants