Adventure: check restrictedEditions and allowedEditions when generating rewards #4572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
when Forge Adventure generates a reward it doesn't check if the requested card(s) editions are permitted by
restrictedEditions
/allowedEditions
, so if someone is building a new world that's initially cloned from the default one, it ends up with "forbidden" reward cards.This PR simply ignores those editions, so for example if a reward is defined as:
but
restrictedEditions
contains M21 and M22, the reward will be chosen among red rares of any non-forbidden edition.