Implement CR 800.4m #189
Implement CR 800.4m #189
Conversation
|
i think it would be better to make a new Game Zone for Effects that stays even if the player has lost the game |
|
I can try it like that but I think we'll still need this part for stuff that is not done with effect cards (currently those all get exiled onPlayerLost anyway) |
|
it might work for now, but some effects needs to continue after the player left the game and for such effects i want an extra global Zone, that may not pollute the GUI |
| Player p = game.getRegisteredPlayers().get(oldPlayerIdx); | ||
| if (p.hasLost()) { | ||
| // CR 702.26n | ||
| Untap.doPhasing(p); |
There was a problem hiding this comment.
Will this phase out creatures with Phasing?
There was a problem hiding this comment.
The function could do that for the AP, but since it's called for a player who's no longer around nothing will be there
As per the rule it will phase in those "phased out under the control of a player who has left the game [...] after that player's next turn would have begun"
To set up such a scenario you could:
- steal the creature with a temporary control change effect
- phase it out
- proceed to lose
- the control effect ends, the creature changes to the previous controller's battlefield (while still phased out)
I have to note the timing is slightly off because it should phase in with all the others but the cases where that matters will be even rarer
So for now I feel more comfortable with keeping this rather close together
|
i think i want to refactor the Detain effect anyway later, but for this i want to refactor the "doesn't untap" part first |
|
Well that Detain was just an example - there's lots of different effects that could get stuck in limbo like Shapesharer cloning making a mess I think we can just take the plunge on this PR as it's a step in the right direction...? |
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Example:
Oppononent uses Azorius Arrester trigger on your creature, then you kill him after. Now your creature would have been detained till game end