10 statements out of videos #777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Early results, still need to fix:
|
|
@Betree to be tested, staging need to have CaptainFact/captain-fact-api#309, is there a way to test both of those branches ? |
No, unfortunately matching branches are not configured for CaptainFact CI (that'd be a great addition). I'll test this one locally! |
Remove what's make it fail for now ... Add filters in statement query Add default filter for statements query Add link to go to statement in video debate Add speaker picture to statement Add play icon on video link Hide CommentForm for now ... Add comments filter on statements Remove unused file Remove unused effects Remove logged Remove unused functions Remove unused import Remove unused imports Rename constant Remove comments' effect since they are unused for now... Remove unused code
Betree
force-pushed
the
10_statements_out_of_videos
branch
from
d9e274a
to
b526f0c
Compare
Betree
force-pushed
the
10_statements_out_of_videos
branch
from
309e683
to
1ed6de8
Compare
Betree
reviewed
Jun 19, 2021
|
@vguen souhaites tu finaliser ? |
|
@Miragide oui je souhaite reprendre ce développement. 🙂 |
|
Merci @vguen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend of CaptainFact/captain-fact-api#309
Resolve CaptainFact/captain-fact#10