New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added iframe for statement's source #765
base: staging
Are you sure you want to change the base?
Conversation
Ça en jette ! Il y a deux points qui restent de #765 (comment) qu'on devrait adresser, ça me semble assez important :
|
Les 3 derniers points de @Miragide ont été réalisés. Pour le premier point, après avoir essayé plusieurs solutions, j'en suis venu à la même conclusion @Betree. |
Ça peut se tenter oui, la requête est bloquée à cause des CORS? |
09612d6
to
1aa94df
Compare
Oui. J'ai ajouté la requête côté back et j'ai mis ce message pour résoudre le premier point de @Miragide : Quand tu testeras en local, certains liens ne fonctionneront pas, c'est à cause de cette erreur :
Une idée ? |
1aa94df
to
e804eed
Compare
e804eed
to
ef57872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good implementation, the code is clean & simple. Thank you for exploring this solution @wdestin ❤️
I'm a bit worried about this project, for mainly 3 reasons:
- In terms of UX, sending an API request to check the source every time necessarily means an increased delay to access the source's content which might defeat the initial intent of being able to access sources faster.
- It's tricky to rate-limit it because we don't want to block legit users from accessing the sources, yet with its current state it's very easy to use this endpoint to DDOS another URL (even if it's just a HEAD request).
- I didn't see this complexity coming when I first proposed Show sources without leaving the website captain-fact#26. We can already see that there will be more work to do to make this really safe and useful for users, and to maintain it.
In my opinion, we should cancel the adoption of this feature for now. It's not a pleasure to put aside a great PR like this, but I'm really not confident merging such an important UX change without a proper scoping of all the aspects and a plan to maintain and iterate on it. Given the recent discussions, I also don't think that investing in that feature is a priority for us at the moment.
I agree. We shouldn't implement a feature that doesn't work 100% of the time. It was fun to explore though. 😊 |
Resolve CaptainFact/captain-fact#26
good.mp4
However, there are two downsides to this feature:
meh.mp4